From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH v5 4/4] app/testpmd: add isolated mode parameter Date: Thu, 29 Jun 2017 18:53:22 +0200 Message-ID: <20170629165322.GR19852@6wind.com> References: <0dca86aa1372d6ff09d0aff01d522c580e0e24ab.1495717153.git.vasilyf@mellanox.com> <14badd6d6cb1db131832f3e406ed86e34c7938e9.1498658407.git.vasilyf@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, Nelio Laranjeiro , "Wu, Jingjing" , Thomas Monjalon To: Vasily Philipov Return-path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 193EF2904 for ; Thu, 29 Jun 2017 18:53:31 +0200 (CEST) Received: by mail-wr0-f175.google.com with SMTP id c11so192646461wrc.3 for ; Thu, 29 Jun 2017 09:53:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <14badd6d6cb1db131832f3e406ed86e34c7938e9.1498658407.git.vasilyf@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 28, 2017 at 05:03:57PM +0300, Vasily Philipov wrote: > In case if --isolated-mode parameter was added to the command line > the rte flow isolate action will be applied on each port before > the device configuring. > > Signed-off-by: Vasily Philipov The patch itself looks OK but I think the commit log needs some clarification, here's another suggestion: app/testpmd: add isolated mode parameter Providing this parameter requests flow API isolated mode on all ports at initialization time. It ensures all traffic is received through the configured flow rules only (see flow command). Ports that do not support this mode are automatically discarded. -- Adrien Mazarguil 6WIND