From: "Radim Krčmář" <rkrcmar@redhat.com>
To: kvm@vger.kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
David Matlack <dmatlack@google.com>,
Peter Feiner <pfeiner@google.com>
Subject: [kvm-unit-tests PATCH 1/3] x86/vmx: fix EPT - MMIO access
Date: Thu, 29 Jun 2017 19:26:45 +0200 [thread overview]
Message-ID: <20170629172647.22188-2-rkrcmar@redhat.com> (raw)
In-Reply-To: <20170629172647.22188-1-rkrcmar@redhat.com>
Reading the memory mapped page with x2apic is a bug. Use the generic reader
instead. An alternative would be to disable x2apic.
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
---
x86/vmx_tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index 1f439522cad8..7be016ce4fbc 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -1031,7 +1031,7 @@ static int ept_init_common(bool have_ad)
install_ept(pml4, (unsigned long)data_page1, (unsigned long)data_page2,
EPT_RA | EPT_WA | EPT_EA);
- apic_version = *((u32 *)0xfee00030UL);
+ apic_version = apic_read(APIC_LVR);
return VMX_TEST_START;
}
--
2.13.2
next prev parent reply other threads:[~2017-06-29 17:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 17:26 [kvm-unit-tests PATCH 0/3] x86/vmx: fix vmx_EPT_AD_* tests Radim Krčmář
2017-06-29 17:26 ` Radim Krčmář [this message]
2017-06-29 17:34 ` [kvm-unit-tests PATCH 1/3] x86/vmx: fix EPT - MMIO access Peter Feiner
2017-06-30 10:22 ` Paolo Bonzini
2017-07-03 17:13 ` Radim Krčmář
2017-07-03 17:28 ` Paolo Bonzini
2017-06-29 17:26 ` [kvm-unit-tests PATCH 2/3] x86/vmx: fix detection of unmapped PTE Radim Krčmář
2017-06-29 17:38 ` Peter Feiner
2017-06-30 10:33 ` Paolo Bonzini
2017-07-03 10:34 ` Paolo Bonzini
2017-07-03 16:42 ` Radim Krčmář
2017-06-29 17:26 ` [kvm-unit-tests PATCH 3/3] x86/vmx: get EPT at the last level Radim Krčmář
2017-06-29 17:51 ` Peter Feiner
2017-06-29 18:08 ` Radim Krčmář
2017-06-29 18:17 ` Peter Feiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629172647.22188-2-rkrcmar@redhat.com \
--to=rkrcmar@redhat.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pfeiner@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.