From: Adam Borowski <kilobyte@angband.pl>
To: Nick Terrell <terrelln@fb.com>
Cc: kernel-team@fb.com, Chris Mason <clm@fb.com>,
Yann Collet <cyan@fb.com>,
linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH] btrfs: Keep one more workspace around
Date: Fri, 30 Jun 2017 02:14:16 +0200 [thread overview]
Message-ID: <20170630001416.ib3dbh26sbcp6pz7@angband.pl> (raw)
In-Reply-To: <20170629175726.1246810-1-terrelln@fb.com>
On Thu, Jun 29, 2017 at 10:57:26AM -0700, Nick Terrell wrote:
> The time it took to execute cp vmlinux /mnt/btrfs && sync
> dropped from 1.70s to 1.44s with lzo compression, and from 2.04s to 1.80s
> for zstd compression.
> - if (*free_ws < num_online_cpus()) {
> + if (*free_ws <= num_online_cpus()) {
A simple, self-contained, one-character fix that gives a nice speed-up.
What about getting this for 4.13 or perhaps even 4.9?
Workspace flickering is not a very serious bug, but if we can restore wasted
write speed _this_ easily...
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ A dumb species has no way to open a tuna can.
⢿⡄⠘⠷⠚⠋⠀ A smart species invents a can opener.
⠈⠳⣄⠀⠀⠀⠀ A master species delegates.
next prev parent reply other threads:[~2017-06-30 0:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 17:57 [PATCH] btrfs: Keep one more workspace around Nick Terrell
2017-06-30 0:14 ` Adam Borowski [this message]
2017-06-30 0:49 ` Omar Sandoval
-- strict thread matches above, loose matches on Subject: below --
2017-06-29 1:02 [PATCH] lib/zstd: use div_u64() to let it build on 32-bit Adam Borowski
2017-06-29 3:01 ` [PATCH] btrfs: Keep one more workspace around Nick Terrell
2017-06-29 13:59 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630001416.ib3dbh26sbcp6pz7@angband.pl \
--to=kilobyte@angband.pl \
--cc=clm@fb.com \
--cc=cyan@fb.com \
--cc=dsterba@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.