Re: Build failure in -next due to 'sh: thin archives fix linking'

[Nicholas Piggin <npiggin@gmail.com>]

On Fri, 30 Jun 2017 00:36:42 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> Hi.
> 
> 2017-06-28 23:02 GMT+09:00 Guenter Roeck <linux@roeck-us.net>:
> > On 06/28/2017 05:58 AM, Nicholas Piggin wrote:  
> >>
> >> On Wed, 28 Jun 2017 05:38:50 -0700
> >> Guenter Roeck <linux@roeck-us.net> wrote:
> >>  
> >>> Hi,
> >>>
> >>> I see the following build error in -next when building
> >>> sh:rts7751r2dplus_defconfig.
> >>>
> >>> sh4-linux-ld: arch/sh/kernel/vsyscall/vsyscall-dummy.o: compiled for a
> >>> big endian system and target is little endian
> >>> sh4-linux-ld: arch/sh/kernel/vsyscall/vsyscall-dummy.o: uses instructions
> >>> which are incompatible with instructions used in previous modules
> >>> sh4-linux-ld: failed to merge target specific data of file
> >>> arch/sh/kernel/vsyscall/vsyscall-dummy.o
> >>> make[2]: *** [arch/sh/kernel/vsyscall/vsyscall-syms.o] Error 1
> >>>
> >>> Bisect points to 'sh: thin archives fix linking' as the culprit. Bisect
> >>> log is attached.
> >>> I tried with gcc 4.8.3 and 6.3.0, both built with buildroot for sh4eb.  
> >>
> >>
> >> Thanks for the report. In arch/sh/kernel/vsyscall/Makefile, the line:
> >>
> >>   cmd_syscall_syms = $(LD) -r -o $@ -R $<
> >>
> >> Can you try adding $(LDFLAGS), e.g. change it to:
> >>
> >>   cmd_syscall_syms = $(LD) $(LDFLAGS) -r -o $@ -R $<
> >>  
> >
> > That fixes the problem (including the missing symbols seen after reverting
> > the offending patch).  
> 
> 
> Thanks!
> 
> Instead of adding $(LDFLAGS), how about using cmd_ld?
> 
> 
> Please see line 260 of scripts/Makefile.lib
> 
> quiet_cmd_ld = LD      $@
> cmd_ld = $(LD) $(LDFLAGS) $(ldflags-y) $(LDFLAGS_$(@F)) \
>                $(filter-out FORCE,$^) -o $@
> 
> We can reuse it and $(LDFLAGS) is already there.
> 
> 
> 
> I also noticed redundant "targets += gate-syms.o"
> I see "obj-y += gate-syms.o" and $(obj-y) is automatically
> added to "targets".
> 
> 
> The following diff is my proposal.
> If it is OK, I will squash it and update the thin-ar branch.

Yes, I think this is much better. Thank you! Please squash it in.

Thanks,
Nick