From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751823AbdF3D1r (ORCPT ); Thu, 29 Jun 2017 23:27:47 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:35657 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbdF3D1p (ORCPT ); Thu, 29 Jun 2017 23:27:45 -0400 Date: Fri, 30 Jun 2017 08:57:41 +0530 From: Viresh Kumar To: Srinivas Pandruvada Cc: Rafael Wysocki , Ingo Molnar , Peter Zijlstra , Len Brown , linux-pm@vger.kernel.org, Vincent Guittot , linux-kernel@vger.kernel.org, smuckle.linux@gmail.com, juri.lelli@arm.com, Morten.Rasmussen@arm.com, patrick.bellasi@arm.com, eas-dev@lists.linaro.org Subject: Re: [PATCH V2 3/4] intel_pstate: Ignore scheduler cpufreq callbacks on remote CPUs Message-ID: <20170630032741.GT29665@vireshk-i7> References: <1498771438.7952.118.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498771438.7952.118.camel@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29-06-17, 14:23, Srinivas Pandruvada wrote: > On Thu, 2017-06-29 at 10:56 +0530, Viresh Kumar wrote: > > From: Steve Muckle > > > > In preparation for the scheduler cpufreq callback happening on remote > > CPUs, check for this case in intel_pstate which currently requires > > the > > callback run on the local CPU. Such callbacks are ignored for now. > Is it possible that we miss a chance to calculate load periodically at > a predefined interval (10ms default), because the callback happened on > a different CPU? We aren't updating cpu->sample.time for remote callbacks here, so no we shouldn't miss anything. -- viresh