From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751898AbdF3IZ4 (ORCPT ); Fri, 30 Jun 2017 04:25:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:59294 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751847AbdF3IZz (ORCPT ); Fri, 30 Jun 2017 04:25:55 -0400 Date: Fri, 30 Jun 2017 10:25:51 +0200 From: Michal Hocko To: Roman Gushchin Cc: linux-mm@kvack.org, Vladimir Davydov , Johannes Weiner , Tejun Heo , Tetsuo Handa , kernel-team@fb.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v3 5/6] mm, oom: don't mark all oom victims tasks with TIF_MEMDIE Message-ID: <20170630082551.GB22917@dhcp22.suse.cz> References: <1498079956-24467-1-git-send-email-guro@fb.com> <1498079956-24467-6-git-send-email-guro@fb.com> <20170629085357.GF31603@dhcp22.suse.cz> <20170629184513.GA27714@castle> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170629184513.GA27714@castle> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 29-06-17 14:45:13, Roman Gushchin wrote: > On Thu, Jun 29, 2017 at 10:53:57AM +0200, Michal Hocko wrote: > > On Wed 21-06-17 22:19:15, Roman Gushchin wrote: > > > We want to limit the number of tasks which are having an access > > > to the memory reserves. To ensure the progress it's enough > > > to have one such process at the time. > > > > > > If we need to kill the whole cgroup, let's give an access to the > > > memory reserves only to the first process in the list, which is > > > (usually) the biggest process. > > > This will give us good chances that all other processes will be able > > > to quit without an access to the memory reserves. > > > > I don't like this to be honest. Is there any reason to go the reduced > > memory reserves access to oom victims I was suggesting earlier [1]? > > > > [1] http://lkml.kernel.org/r/http://lkml.kernel.org/r/1472723464-22866-2-git-send-email-mhocko@kernel.org > > I've nothing against your approach. What's the state of this patchset? > Do you plan to bring it upstream? Just the specific patch I have linked should be sufficient for what you need here. The patchset had some issues which I didn't have time to fix and as such the need for the above patch was not a high priority as well. -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [v3 5/6] mm, oom: don't mark all oom victims tasks with TIF_MEMDIE Date: Fri, 30 Jun 2017 10:25:51 +0200 Message-ID: <20170630082551.GB22917@dhcp22.suse.cz> References: <1498079956-24467-1-git-send-email-guro@fb.com> <1498079956-24467-6-git-send-email-guro@fb.com> <20170629085357.GF31603@dhcp22.suse.cz> <20170629184513.GA27714@castle> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20170629184513.GA27714@castle> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Roman Gushchin Cc: linux-mm@kvack.org, Vladimir Davydov , Johannes Weiner , Tejun Heo , Tetsuo Handa , kernel-team@fb.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org On Thu 29-06-17 14:45:13, Roman Gushchin wrote: > On Thu, Jun 29, 2017 at 10:53:57AM +0200, Michal Hocko wrote: > > On Wed 21-06-17 22:19:15, Roman Gushchin wrote: > > > We want to limit the number of tasks which are having an access > > > to the memory reserves. To ensure the progress it's enough > > > to have one such process at the time. > > > > > > If we need to kill the whole cgroup, let's give an access to the > > > memory reserves only to the first process in the list, which is > > > (usually) the biggest process. > > > This will give us good chances that all other processes will be able > > > to quit without an access to the memory reserves. > > > > I don't like this to be honest. Is there any reason to go the reduced > > memory reserves access to oom victims I was suggesting earlier [1]? > > > > [1] http://lkml.kernel.org/r/http://lkml.kernel.org/r/1472723464-22866-2-git-send-email-mhocko@kernel.org > > I've nothing against your approach. What's the state of this patchset? > Do you plan to bring it upstream? Just the specific patch I have linked should be sufficient for what you need here. The patchset had some issues which I didn't have time to fix and as such the need for the above patch was not a high priority as well. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org