From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQwIp-0002QZ-IO for qemu-devel@nongnu.org; Fri, 30 Jun 2017 09:49:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQwIm-0001Ig-DD for qemu-devel@nongnu.org; Fri, 30 Jun 2017 09:49:43 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:31064) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1dQwIm-0001IE-6l for qemu-devel@nongnu.org; Fri, 30 Jun 2017 09:49:40 -0400 Date: Fri, 30 Jun 2017 14:49:35 +0100 From: Anthony PERARD Message-ID: <20170630134935.GE1598@perard.uk.xensource.com> References: <1498715394-16402-1-git-send-email-tianyu.lan@intel.com> <1498715394-16402-2-git-send-email-tianyu.lan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1498715394-16402-2-git-send-email-tianyu.lan@intel.com> Subject: Re: [Qemu-devel] [PATCH 1/3] i386/msi: Correct mask of destination ID in MSI address List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lan Tianyu Cc: qemu-devel@nongnu.org, xen-devel@lists.xensource.com, Chao Gao , mst@redhat.com, marcel@redhat.com, sstabellini@kernel.org, kevin.tian@intel.com On Thu, Jun 29, 2017 at 01:49:52AM -0400, Lan Tianyu wrote: > From: Chao Gao > > According to SDM 10.11.1, only [19:12] bits of MSI address are > Destination ID, change the mask to avoid ambiguity for VT-d spec > has used the bit 4 to indicate a remappable interrupt request. > > Signed-off-by: Chao Gao > Signed-off-by: Lan Tianyu Reviewed-by: Anthony PERARD > --- > include/hw/i386/apic-msidef.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/i386/apic-msidef.h b/include/hw/i386/apic-msidef.h > index 8b4d4cc..420b411 100644 > --- a/include/hw/i386/apic-msidef.h > +++ b/include/hw/i386/apic-msidef.h > @@ -26,6 +26,6 @@ > > #define MSI_ADDR_DEST_ID_SHIFT 12 > #define MSI_ADDR_DEST_IDX_SHIFT 4 > -#define MSI_ADDR_DEST_ID_MASK 0x00ffff0 > +#define MSI_ADDR_DEST_ID_MASK 0x000ff000 > > #endif /* HW_APIC_MSIDEF_H */ -- Anthony PERARD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH 1/3] i386/msi: Correct mask of destination ID in MSI address Date: Fri, 30 Jun 2017 14:49:35 +0100 Message-ID: <20170630134935.GE1598@perard.uk.xensource.com> References: <1498715394-16402-1-git-send-email-tianyu.lan@intel.com> <1498715394-16402-2-git-send-email-tianyu.lan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1498715394-16402-2-git-send-email-tianyu.lan@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Lan Tianyu Cc: kevin.tian@intel.com, sstabellini@kernel.org, mst@redhat.com, qemu-devel@nongnu.org, xen-devel@lists.xensource.com, marcel@redhat.com, Chao Gao List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBKdW4gMjksIDIwMTcgYXQgMDE6NDk6NTJBTSAtMDQwMCwgTGFuIFRpYW55dSB3cm90 ZToKPiBGcm9tOiBDaGFvIEdhbyA8Y2hhby5nYW9AaW50ZWwuY29tPgo+IAo+IEFjY29yZGluZyB0 byBTRE0gMTAuMTEuMSwgb25seSBbMTk6MTJdIGJpdHMgb2YgTVNJIGFkZHJlc3MgYXJlCj4gRGVz dGluYXRpb24gSUQsIGNoYW5nZSB0aGUgbWFzayB0byBhdm9pZCBhbWJpZ3VpdHkgZm9yIFZULWQg c3BlYwo+IGhhcyB1c2VkIHRoZSBiaXQgNCB0byBpbmRpY2F0ZSBhIHJlbWFwcGFibGUgaW50ZXJy dXB0IHJlcXVlc3QuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hhbyBHYW8gPGNoYW8uZ2FvQGludGVs LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBMYW4gVGlhbnl1IDx0aWFueXUubGFuQGludGVsLmNvbT4K ClJldmlld2VkLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4K Cj4gLS0tCj4gIGluY2x1ZGUvaHcvaTM4Ni9hcGljLW1zaWRlZi5oIHwgMiArLQo+ICAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEv aW5jbHVkZS9ody9pMzg2L2FwaWMtbXNpZGVmLmggYi9pbmNsdWRlL2h3L2kzODYvYXBpYy1tc2lk ZWYuaAo+IGluZGV4IDhiNGQ0Y2MuLjQyMGI0MTEgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9ody9p Mzg2L2FwaWMtbXNpZGVmLmgKPiArKysgYi9pbmNsdWRlL2h3L2kzODYvYXBpYy1tc2lkZWYuaAo+ IEBAIC0yNiw2ICsyNiw2IEBACj4gIAo+ICAjZGVmaW5lIE1TSV9BRERSX0RFU1RfSURfU0hJRlQg ICAgICAgICAgMTIKPiAgI2RlZmluZSBNU0lfQUREUl9ERVNUX0lEWF9TSElGVCAgICAgICAgIDQK PiAtI2RlZmluZSAgTVNJX0FERFJfREVTVF9JRF9NQVNLICAgICAgICAgIDB4MDBmZmZmMAo+ICsj ZGVmaW5lICBNU0lfQUREUl9ERVNUX0lEX01BU0sgICAgICAgICAgMHgwMDBmZjAwMAo+ICAKPiAg I2VuZGlmIC8qIEhXX0FQSUNfTVNJREVGX0ggKi8KCi0tIApBbnRob255IFBFUkFSRAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxp bmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVu LWRldmVsCg==