All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
	qemu-devel@nongnu.org, alistair.francis@xilinx.com,
	edgar.iglesias@gmail.com, mst@redhat.com, afaerber@suse.de,
	qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback
Date: Fri, 30 Jun 2017 22:21:53 +0800	[thread overview]
Message-ID: <20170630142153.GA26114@lemon> (raw)
In-Reply-To: <41be440c-e158-fb83-15dd-e9853460d5a3@redhat.com>

On Fri, 06/30 12:41, Paolo Bonzini wrote:
> 
> 
> On 29/06/2017 13:14, Igor Mammedov wrote:
> > link's check callback is supposed to verify/permit setting it,
> > however currently nothing restricts it from misusing it
> > and modifying target object from within.
> > Make sure that readonly semantics are checked by compiler
> > to prevent callback's misuse.
> > 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> > Fam,
> >  it probably conflicts with yours DEFINE_PROP_LINK series,
> >  feel free to include this patch if you'll have to respin
> 
> Since there will be a respin, I'm _not_ queuing this patch.

I am going to include this in my next version of DEFINE_PROP_LINK series.

Fam

  reply	other threads:[~2017-06-30 14:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29 11:14 [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback Igor Mammedov
2017-06-29 13:45 ` Paolo Bonzini
2017-06-29 15:38   ` Igor Mammedov
2017-06-30 10:41 ` Paolo Bonzini
2017-06-30 14:21   ` Fam Zheng [this message]
2017-07-06  7:16 ` no-reply
2017-07-06  7:29   ` Fam Zheng
2017-07-06 23:50 ` no-reply
2017-07-07  0:01   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170630142153.GA26114@lemon \
    --to=famz@redhat.com \
    --cc=afaerber@suse.de \
    --cc=alistair.francis@xilinx.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.