From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752009AbdF3Psl (ORCPT ); Fri, 30 Jun 2017 11:48:41 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:60117 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751675AbdF3Psk (ORCPT ); Fri, 30 Jun 2017 11:48:40 -0400 From: Arnd Bergmann To: Andrew Morton , "Luis R. Rodriguez" Cc: Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [PATCH] kmod: add dependencies for test module Date: Fri, 30 Jun 2017 17:47:44 +0200 Message-Id: <20170630154834.3689272-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:OT3L9mupzcwqWzs/XGUPlugnKW2R3HG0mJbcugkKPYG8p/79Ugj mCcQFsl/HfG2TNwfQ+P10nrIPLUTqbSmH36Bsk6ugfFsFjIzbq5UbZal4fzifgPFEDZKv6/ UFiGP83a5VTaEYeOlOYYfT5HjJbmuyLDnQ1m9eaf5Fz31/AtwvA1yIeWGgBM3ePdzeFoGIV cxk2Cyl4BAov07ZLiHMag== X-UI-Out-Filterresults: notjunk:1;V01:K0:xfFOcZSvkCs=:DdnVJct0YGxe2uyygK1DoZ t1j0e1gLPRe+hpDaaJICMhfUmgbGmv6uNSom21P1gAvrRxTIJ0NuoXjfL1ClSlUUwG45hEpif /SLAjYwjqcgzjMeANUh60t9ByUBhYQ4EkDP1aXmyVUr3LBx9OzdyaXoyzo0WJI/NoCxEefWTp ViDIJzGAAUlRviHbmp0DRU1EL9iuprNv/6YjyR9qvRemWeG2T0K/NVfLemIuwLAdSZoGFy9nV R6+nItJwb5bCTO+SFf1TUBncm9OvbDo+B9T05CVb8cr7g1qJWXkpXy3GRm8jtTAOuw1aOLG98 jGXbXx1xSsWpT1b6z0/fAo/GgjmR9eN6dO+EF0o1eQt0w09Cs6m9qaPbf3rWZd9VwH8xtZ2cw WUsjLp2slGSaoIIGwYYn0Nnbh/r0CDySMZGZC3Rw9MbQrLf2PKBOahkMRp6Chw92Cim/OUZTJ s17UIwocl3zKcvdLYKkHBkU4hch94BxZKgcKkF7G2248kqAz8JeyZnhWIM+3mDZIO9rpLmKXq aup0Utc/mNLC1vtb0sq7YhOrTWKlcYVcxXmGlUiEVFS7O/diqEUwugFjfjFguRKtwpv0z/v3J Q638y5r0gNGxSA+Ji7EyqKxgtlTV13h6GM00zlqd+qUo3SsPXWPM+Y7yG3fSf2UugelNcSU+k pfn6majm3XhDnx1ohU22GwF8Cqdu+5H0OfOReAoHhZykzHZAFyeBW9skseooCxnzC3iw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When we try to 'select' drivers whose dependencies are not met, we get a kconfig warning and undefined behavior as further 'select' statements in those drivers can not be honored: warning: (TEST_KMOD) selects TUN which has unmet direct dependencies (NETDEVICES && NET_CORE && INET) warning: (TEST_KMOD) selects XFS_FS which has unmet direct dependencies (BLOCK && (64BIT || LBDAF)) ERROR: "iomap_zero_range" [fs/xfs/xfs.ko] undefined! ERROR: "iomap_fiemap" [fs/xfs/xfs.ko] undefined! ERROR: "iomap_page_mkwrite" [fs/xfs/xfs.ko] undefined! To work around that, this adds the dependencies required by the 'tun', 'xfs' and 'btrfs' modules for CONFIG_TEST_KMOD, guaranteeing that we can always enable those, and fixing the 'randconfig' issues. Unfortunately, there is another problem that I have not found a good solution for: If any of the three drivers are built-in rather than loadable modules, then the module load test will later fail at runtime. Fixes: ec159fed8677 ("kmod: add test driver to stress test the module loader") Signed-off-by: Arnd Bergmann --- lib/Kconfig.debug | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 411cddd713c0..0f7ba738ef7a 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1883,6 +1883,8 @@ config TEST_KMOD tristate "kmod stress tester" default n depends on m + depends on BLOCK && (64BIT || LBDAF) # for XFS, BTRFS + depends on NETDEVICES && NET_CORE && INET # for TUN select TEST_LKM select XFS_FS select TUN -- 2.9.0