From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752079AbdGAHsH (ORCPT ); Sat, 1 Jul 2017 03:48:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:33290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbdGAHsF (ORCPT ); Sat, 1 Jul 2017 03:48:05 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2169922BC9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jaegeuk@kernel.org Date: Sat, 1 Jul 2017 00:48:04 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: Re: [PATCH 2/2] f2fs: reuse original mount option in ->remount_fs Message-ID: <20170701074804.GB85052@jaegeuk-macbookpro.roam.corp.google.com> References: <20170629152046.2610-1-chao@kernel.org> <20170629152046.2610-2-chao@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170629152046.2610-2-chao@kernel.org> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/29, Chao Yu wrote: > From: Chao Yu > > Don't clear old mount option before parse new option during ->remount_fs > like other generic filesystems. So, what happened on your original patch? commit 26666c8a4366debae30ae37d0688b2bec92d196a f2fs: fix to clean previous mount option when remount_fs I think we need to rever the original patch tho. Thanks, > > Signed-off-by: Chao Yu > --- > fs/f2fs/super.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index f27c141cd8aa..af472f7968d0 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -846,7 +846,6 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) > clear_sbi_flag(sbi, SBI_NEED_SB_WRITE); > } > > - sbi->mount_opt.opt = 0; > default_options(sbi); > > /* parse mount options */ > -- > 2.13.0.90.g1eb437020