From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH 06/33] app/testeventdev: define the test
 options
Date: Mon, 3 Jul 2017 12:40:34 +0530
Message-ID: <20170703071032.GA23948@jerin>
References: <20170528195854.6064-1-jerin.jacob@caviumnetworks.com>
 <20170528195854.6064-7-jerin.jacob@caviumnetworks.com>
 <E923DB57A917B54B9182A2E928D00FA640C31625@IRSMSX102.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
 "Eads, Gage" <gage.eads@intel.com>,
 "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
 "Vangati, Narender" <narender.vangati@intel.com>,
 "Rao, Nikhil" <nikhil.rao@intel.com>,
 "gprathyusha@caviumnetworks.com" <gprathyusha@caviumnetworks.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0082.outbound.protection.outlook.com [104.47.36.82])
 by dpdk.org (Postfix) with ESMTP id 354B82C39
 for <dev@dpdk.org>; Mon,  3 Jul 2017 09:10:57 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA640C31625@IRSMSX102.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Fri, 23 Jun 2017 13:07:10 +0000
> From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "dev@dpdk.org"
>  <dev@dpdk.org>
> CC: "Richardson, Bruce" <bruce.richardson@intel.com>,
>  "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Eads, Gage"
>  <gage.eads@intel.com>, "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
>  "Vangati, Narender" <narender.vangati@intel.com>, "Rao, Nikhil"
>  <nikhil.rao@intel.com>, "gprathyusha@caviumnetworks.com"
>  <gprathyusha@caviumnetworks.com>
> Subject: RE: [dpdk-dev] [PATCH 06/33] app/testeventdev: define the test
>  options
> 
> > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > Sent: Sunday, May 28, 2017 8:58 PM
> > To: dev@dpdk.org
> > Cc: Richardson, Bruce <bruce.richardson@intel.com>; Van Haaren, Harry
> > <harry.van.haaren@intel.com>; hemant.agrawal@nxp.com; Eads, Gage <gage.eads@intel.com>;
> > nipun.gupta@nxp.com; Vangati, Narender <narender.vangati@intel.com>; Rao, Nikhil
> > <nikhil.rao@intel.com>; gprathyusha@caviumnetworks.com; Jerin Jacob
> > <jerin.jacob@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH 06/33] app/testeventdev: define the test options
> > 
> > Define the test options that used across all test cases and
> > fill the default values for the same.
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > Signed-off-by: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
> 
> <snip>
> 
> 
> > +void
> > +evt_options_default(struct evt_options *opt)
> > +{
> > +	memset(opt, 0, sizeof(*opt));
> > +	opt->verbose_level = 1; /* Enable minimal prints */
> > +	opt->dev_id = 0;
> > +	strncpy(opt->test_name, "queue_order", EVT_TEST_NAME_MAX_LEN);
> 
> I think "queue_order" isn't a valid test name, we should probably make the default test to run something that is supported by all PMDs, performance testing of atomic traffic?

Good catch. I will change to "order_queue". It supported on all PMD

> 
> With that resolved,
> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>