From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752248AbdGCDvP (ORCPT ); Sun, 2 Jul 2017 23:51:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:51960 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752157AbdGCDvN (ORCPT ); Sun, 2 Jul 2017 23:51:13 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4983022BD1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org Date: Mon, 3 Jul 2017 12:51:09 +0900 From: Masami Hiramatsu To: Masami Hiramatsu Cc: "Naveen N. Rao" , Steven Rostedt , Ananth N Mavinakayanahalli , Michael Ellerman , Shuah Khan , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] selftests/ftrace: Add a test to probe module functions Message-Id: <20170703125109.191c52bdc0495cc41e742d84@kernel.org> In-Reply-To: <20170703122733.e0f7043415e495352c0a12a9@kernel.org> References: <04c3a67eb5fe13b12725f7198ef9904f992a512a.1498742262.git.naveen.n.rao@linux.vnet.ibm.com> <20170703122733.e0f7043415e495352c0a12a9@kernel.org> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 3 Jul 2017 12:27:33 +0900 Masami Hiramatsu wrote: > On Thu, 29 Jun 2017 19:05:37 +0530 > "Naveen N. Rao" wrote: > > > Add a kprobes test to ensure that we are able to add a probe on a > > module function using 'p :' format, without having to > > specify a probe name. > > > > Suggested-by: Masami Hiramatsu > > Acked-by: Masami Hiramatsu > > Signed-off-by: Naveen N. Rao > > --- > > .../testing/selftests/ftrace/test.d/kprobe/probe_module.tc | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/probe_module.tc > > > > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/probe_module.tc b/tools/testing/selftests/ftrace/test.d/kprobe/probe_module.tc > > new file mode 100644 > > index 000000000000..ea7657041ba6 > > --- /dev/null > > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/probe_module.tc > > @@ -0,0 +1,14 @@ > > +#!/bin/sh > > +# description: Kprobe dynamic event - probing module > > + > > +[ -f kprobe_events ] || exit_unsupported # this is configurable > > + > > +echo 0 > events/enable > > +echo > kprobe_events > > +export MOD=`lsmod | head -n 2 | tail -n 1 | cut -f1 -d" "` > > +export FUNC=`grep -m 1 ".* t .*\\[$MOD\\]" /proc/kallsyms | xargs | cut -f3 -d" "` > > +[ "x" != "x$MOD" -a "y" != "y$FUNC" ] || exit_untested > > Could you also add below case? > > echo p:probe_$MOD/$FUNC $MOD/$FUNC > kprobe_events Oops, it should be something like echo "p:test_${MOD}_${FUNC} $MOD/$FUNC" > kprobe_events since we would like to avoid adding new group name for it. (Adding new group name should be a separated one.) Thank you, > > This is for "new event with name on module" case, your one is for "new event without name on module (automatic name generation)" > > We should have different test case, because those kicks slightly different parts in kprobe tracer. > > Thank you, > > > +echo p $MOD:$FUNC > kprobe_events > > +grep $MOD kprobe_events > > +echo > kprobe_events > > +clear_trace > > -- > > 2.13.1 > > > > > -- > Masami Hiramatsu -- Masami Hiramatsu