From: Wei Liu <wei.liu2@citrix.com>
To: Oleksandr Grytsov <al1img@gmail.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Subject: Re: [PATCH v3 04/11] libxl: add generic function to add device
Date: Mon, 3 Jul 2017 13:57:02 +0100 [thread overview]
Message-ID: <20170703125702.l2lujezuzlqairiy@citrix.com> (raw)
In-Reply-To: <CACvf2oX-ASNncN_e-7k90b-3uznTqvJQ+S9HLYh1KnTFAcQuJw@mail.gmail.com>
On Mon, Jul 03, 2017 at 03:53:08PM +0300, Oleksandr Grytsov wrote:
> On Fri, Jun 30, 2017 at 5:18 PM, Wei Liu <wei.liu2@citrix.com> wrote:
> > On Fri, Jun 30, 2017 at 03:16:38PM +0100, Wei Liu wrote:
> >> On Fri, Jun 30, 2017 at 04:24:23PM +0300, Oleksandr Grytsov wrote:
> >> > On Thu, Jun 29, 2017 at 8:36 PM, Wei Liu <wei.liu2@citrix.com> wrote:
> >> > > On Tue, Jun 27, 2017 at 01:03:20PM +0300, Oleksandr Grytsov wrote:
> >> > >> From: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
> >> > >>
> >> > >> Add libxl__device_add functio.
> >> > >
> >> > > function
> >> > >
> >> > >> Almost all devices have similar libxl__device_xxxx_add function.
> >> > >> This generic function implements same functionality but
> >> > >> using the device handling framework. The device specific
> >> > >> part this is setting xen store configuration. This part
> >> > >> is moved to set_xenstore_config callback of the device framework.
> >> > >>
> >> > >
> >> > > Right. I think this is a good idea in general.
> >> > >
> >> > > I don't see exiting device ported to the new framework, why?
> >> >
> >> > Good question. I think it is a little dangerous and may introduce regression.
> >> > But definitely it should be done. I can do these changes but I don't have
> >> > visibility how to check each device.
> >>
> >> Please just do it. We have a lot of time during development and RC
> >> period for people to test your changes.
> >
> > And I forget to say, please use one patch for one device type.
>
> Should it be in this patch set or better to create new one for each device?
>
Those patches should be in this series. One for each device for ease of
review please, and arrange it a way such that I can partially apply this
series.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-07-03 12:57 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 10:03 [PATCH v3 00/11] libxl: add PV display device driver interface Oleksandr Grytsov
2017-06-27 10:03 ` [PATCH v3 01/11] libxl: add vdispl structures to idl Oleksandr Grytsov
2017-06-29 17:36 ` Wei Liu
2017-06-30 10:36 ` Oleksandr Grytsov
2017-06-30 14:15 ` Wei Liu
2017-06-27 10:03 ` [PATCH v3 02/11] libxl: add API for PV display device driver Oleksandr Grytsov
2017-06-27 10:03 ` [PATCH v3 03/11] libxl: add generic function to get and free device list Oleksandr Grytsov
2017-06-29 17:36 ` Wei Liu
2017-06-30 13:24 ` Oleksandr Grytsov
2017-07-06 15:29 ` Wei Liu
2017-07-10 12:22 ` Oleksandr Grytsov
2017-07-10 12:26 ` Oleksandr Grytsov
2017-07-12 9:51 ` Wei Liu
2017-07-12 13:43 ` Oleksandr Grytsov
2017-07-12 14:06 ` Wei Liu
2017-07-12 9:50 ` Wei Liu
2017-06-27 10:03 ` [PATCH v3 04/11] libxl: add generic function to add device Oleksandr Grytsov
2017-06-29 17:36 ` Wei Liu
2017-06-30 13:24 ` Oleksandr Grytsov
2017-06-30 14:16 ` Wei Liu
2017-06-30 14:18 ` Wei Liu
2017-07-03 12:53 ` Oleksandr Grytsov
2017-07-03 12:57 ` Wei Liu [this message]
2017-07-04 9:41 ` Oleksandr Grytsov
2017-07-12 16:13 ` Oleksandr Grytsov
2017-07-18 13:35 ` Wei Liu
2017-07-06 15:51 ` Wei Liu
2017-07-07 9:49 ` Oleksandr Grytsov
2017-07-07 10:29 ` Oleksandr Grytsov
2017-07-07 10:32 ` Wei Liu
2017-07-07 10:56 ` Oleksandr Grytsov
2017-07-10 12:41 ` Oleksandr Grytsov
2017-07-12 10:12 ` Wei Liu
2017-06-27 10:03 ` [PATCH v3 05/11] libxl: add vdispl setting xen store configuration Oleksandr Grytsov
2017-06-27 10:03 ` [PATCH v3 06/11] libxl: implement vdispl get info function Oleksandr Grytsov
2017-06-27 10:03 ` [PATCH v3 07/11] libxl: implement device_from_vdispl and update_config_vdispl Oleksandr Grytsov
2017-06-27 10:03 ` [PATCH v3 08/11] libxl: add libxl__vdispl_devtype to device_type_tbl Oleksandr Grytsov
2017-06-27 10:03 ` [PATCH v3 09/11] libxl: add libxl_devid_to_device_vdispl interface function Oleksandr Grytsov
2017-06-27 10:03 ` [PATCH v3 10/11] xl: add PV display device commands Oleksandr Grytsov
2017-06-27 10:03 ` [PATCH v3 11/11] docs: add PV display driver information Oleksandr Grytsov
2017-06-29 17:36 ` Wei Liu
2017-06-30 10:43 ` Oleksandr Grytsov
2017-06-29 17:38 ` [PATCH v3 00/11] libxl: add PV display device driver interface Wei Liu
2017-06-30 10:45 ` Oleksandr Grytsov
2017-06-30 14:20 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170703125702.l2lujezuzlqairiy@citrix.com \
--to=wei.liu2@citrix.com \
--cc=al1img@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=oleksandr_grytsov@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.