From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKCh-0000Jm-Lb for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:33:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKCg-00061t-QN for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:33:07 -0400 Date: Tue, 4 Jul 2017 17:32:52 +0800 From: Fam Zheng Message-ID: <20170704093252.GN10298@lemon.lan> References: <20170703221456.30817-1-eblake@redhat.com> <20170703221456.30817-14-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170703221456.30817-14-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 13/15] block: Convert bdrv_get_block_status_above() to bytes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org, el13635@mail.ntua.gr, Jeff Cody , Max Reitz , Stefan Hajnoczi , jsnow@redhat.com On Mon, 07/03 17:14, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. In the common case, allocation is unlikely to ever use > values that are not naturally sector-aligned, but it is possible > that byte-based values will let us be more precise about allocation > at the end of an unaligned file that can do byte-based access. > > Changing the name of the function from bdrv_get_block_status_above() > to bdrv_block_status_above() ensures that the compiler enforces that > all callers are updated. For now, the io.c layer still assert()s > that all callers are sector-aligned, but that can be relaxed when a > later patch implements byte-based block status in the drivers. > > For the most part this patch is just the addition of scaling at the > callers followed by inverse scaling at bdrv_block_status(). But some > code, particularly bdrv_block_status(), gets a lot simpler because > it no longer has to mess with sectors. > > For ease of review, bdrv_get_block_status() was tackled separately. > > Signed-off-by: Eric Blake Reviewed-by: Fam Zheng