From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Date: Tue, 04 Jul 2017 14:03:34 +0000 Subject: Re: [PATCH 2/6] i2c: pca-platform: correctly set algo_data.reset_chip Message-Id: <20170704140333.iahb7udd22ph6awk@ninjato> MIME-Version: 1 Content-Type: multipart/mixed; boundary="5thzgr52ilotzhge" List-Id: References: <20170630005408.23968-1-chris.packham@alliedtelesis.co.nz> <20170630005408.23968-3-chris.packham@alliedtelesis.co.nz> In-Reply-To: <20170630005408.23968-3-chris.packham@alliedtelesis.co.nz> To: Chris Packham Cc: andy.shevchenko@gmail.com, linux-i2c@vger.kernel.org, ysato@users.sourceforge.jp, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org --5thzgr52ilotzhge Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 30, 2017 at 12:54:04PM +1200, Chris Packham wrote: > When device tree support was added the setting of algo_data.reset_chip > was moved. There were two problems with this. The first being that > i2c_pca_pf_resetchip was only used if platform data was provided. The > second that it was unconditionally overridden with > i2c_pca_pf_dummyreset. Ensure that however the reset gpio is defined the > correct reset_chip function is used. >=20 > Fixes: commit 4cc7229daa46 ("i2c: pca-platform: switch to struct gpio_des= c") > Signed-off-by: Chris Packham It's a bugfix, so I'll include it in this merge window. Applied to for-next, thanks! --5thzgr52ilotzhge Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAllboDUACgkQFA3kzBSg KbbtPw//XQD0e7td5ohv5+ktnC70xdPFz34LrefB7y6Z34FRDvjbp1PSQirQy8Ap cobMfdHksEQ0CDTMcdDYBsD8ijpEpr03JOVWEPjE1eFvUnea56MSl/z41Bzdnx4a QT4iNZWfBz9GdcP7CFlUGMXoAwkHpTeyJu2S2wpe/9rgJDYDDGUAuhX8DSKNL5QV nSuQ3KtcGNANnB/bR5sj7TrV5/ZtGSCrTdNapi3uKOPW4M3YRp9XftmDXwAkeEgv 0uNLwKdG+ac4LOWLFZyNIa8R4OUgwrc7OlOVbLDXFkQECfjBcA+0aXZtIgbz8R2f C1Ggf00dXwIHpVjsPEw1JwcYBbcPsoiEEul1djz12+UF5sgc56f36xrIEcurkIDY rAWGVSItKBSnlXepF8OMKR+bn3ZlXBiSyAgKpkhRdG6Zy7iIdMeLnScKL1i5wwLr vCKVUsyq+ZL/RT13iFt7S9LwQaBxNGLwkjg1nWltEK6jWYeaBrknHSOl5WXMfCH9 DandR8XPW7Tioh4v64+kykc6b1wzN40xMquN1m+DLz6rvFIq7ZkmxNWqhFvhorO2 a/yjoppWySaV3nrVtpijZUWc1ort6ZpnMcFyC2Xh/GzarUXx1lL5Fb0YRN6YbcPR IAbea74GUMOWbAXjfiInGDu15TQuXNEX/BglYLoMlJfwDrwal3Y= =Iz2L -----END PGP SIGNATURE----- --5thzgr52ilotzhge-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752472AbdGDODi (ORCPT ); Tue, 4 Jul 2017 10:03:38 -0400 Received: from sauhun.de ([88.99.104.3]:49175 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752067AbdGDODg (ORCPT ); Tue, 4 Jul 2017 10:03:36 -0400 Date: Tue, 4 Jul 2017 16:03:34 +0200 From: Wolfram Sang To: Chris Packham Cc: andy.shevchenko@gmail.com, linux-i2c@vger.kernel.org, ysato@users.sourceforge.jp, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] i2c: pca-platform: correctly set algo_data.reset_chip Message-ID: <20170704140333.iahb7udd22ph6awk@ninjato> References: <20170630005408.23968-1-chris.packham@alliedtelesis.co.nz> <20170630005408.23968-3-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5thzgr52ilotzhge" Content-Disposition: inline In-Reply-To: <20170630005408.23968-3-chris.packham@alliedtelesis.co.nz> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5thzgr52ilotzhge Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 30, 2017 at 12:54:04PM +1200, Chris Packham wrote: > When device tree support was added the setting of algo_data.reset_chip > was moved. There were two problems with this. The first being that > i2c_pca_pf_resetchip was only used if platform data was provided. The > second that it was unconditionally overridden with > i2c_pca_pf_dummyreset. Ensure that however the reset gpio is defined the > correct reset_chip function is used. >=20 > Fixes: commit 4cc7229daa46 ("i2c: pca-platform: switch to struct gpio_des= c") > Signed-off-by: Chris Packham It's a bugfix, so I'll include it in this merge window. Applied to for-next, thanks! --5thzgr52ilotzhge Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAllboDUACgkQFA3kzBSg KbbtPw//XQD0e7td5ohv5+ktnC70xdPFz34LrefB7y6Z34FRDvjbp1PSQirQy8Ap cobMfdHksEQ0CDTMcdDYBsD8ijpEpr03JOVWEPjE1eFvUnea56MSl/z41Bzdnx4a QT4iNZWfBz9GdcP7CFlUGMXoAwkHpTeyJu2S2wpe/9rgJDYDDGUAuhX8DSKNL5QV nSuQ3KtcGNANnB/bR5sj7TrV5/ZtGSCrTdNapi3uKOPW4M3YRp9XftmDXwAkeEgv 0uNLwKdG+ac4LOWLFZyNIa8R4OUgwrc7OlOVbLDXFkQECfjBcA+0aXZtIgbz8R2f C1Ggf00dXwIHpVjsPEw1JwcYBbcPsoiEEul1djz12+UF5sgc56f36xrIEcurkIDY rAWGVSItKBSnlXepF8OMKR+bn3ZlXBiSyAgKpkhRdG6Zy7iIdMeLnScKL1i5wwLr vCKVUsyq+ZL/RT13iFt7S9LwQaBxNGLwkjg1nWltEK6jWYeaBrknHSOl5WXMfCH9 DandR8XPW7Tioh4v64+kykc6b1wzN40xMquN1m+DLz6rvFIq7ZkmxNWqhFvhorO2 a/yjoppWySaV3nrVtpijZUWc1ort6ZpnMcFyC2Xh/GzarUXx1lL5Fb0YRN6YbcPR IAbea74GUMOWbAXjfiInGDu15TQuXNEX/BglYLoMlJfwDrwal3Y= =Iz2L -----END PGP SIGNATURE----- --5thzgr52ilotzhge--