[Cocci] Matching format strings

[okuznik@symas.com (Ondřej Kuzník)]

On Tue, Jul 04, 2017 at 03:53:21PM +0200, Julia Lawall wrote:
> On Tue, 4 Jul 2017, Ond?ej Kuzn?k wrote:
>> That does work and seems to preserve the things that needed escaping,
>> so just putting quotes around when merging looks enough, great!
>>
>> There is another scenario that I probably need to be able to handle, a
>> string like this does not seem to match anything I throw at it (and in
>> retrospect, you might have mentioned that earlier):
>>
>> "asd" "fgh" "jkl"
>>
>> Is there a way around that somehow or match, then pass into python to
>> handle that?
> 
> This is in the C code?  I think that it should be matched by an
> expression.

Hmm, suddenly the problems with passing expressions to python I stated
earlier disappeared, good. Running this takes a log time on some files
(over 10 minutes for ./servers/slapd/back-ldap/bind.c and processing of
servers/slapd/back-meta/search.c has yet to finish after 30 minutes of
processing).

I suppose going through all the potential combinations of snprintf/Debug
statements is what takes so long, any tips on what usually helps to
speed things up?

Also, more importantly, the patch below this seems to remove this
comment:
https://github.com/openldap/openldap/blob/master/servers/slapd/back-asyncmeta/conn.c#L547

{
...
-T buf;
...
ldap_pvt_thread_mutex_lock(lock);
...
-snprintf at p1( buf, E, format1, args );
+Debug( L, merged, args_before, args, args_after );
...
ldap_pvt_thread_mutex_unlock(lock);
...
-Debug at p2( L, format2, args_before, buf, args_after );
...
}

I would like to preserve the comment, is there something I can do about
that?

Thanks,

-- 
Ond?ej Kuzn?k
Senior Software Engineer
Symas Corporation                       http://www.symas.com
Packaged, certified, and supported LDAP solutions powered by OpenLDAP