From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752676AbdGDTyb (ORCPT ); Tue, 4 Jul 2017 15:54:31 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:58765 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752296AbdGDTy3 (ORCPT ); Tue, 4 Jul 2017 15:54:29 -0400 Date: Tue, 4 Jul 2017 21:54:22 +0200 From: Maxime Ripard To: Jonathan Liu Cc: David Airlie , Chen-Yu Tsai , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v8] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus Message-ID: <20170704195422.hsi4lhzlqb75gm4n@flea> References: <20170702072710.29988-1-net147@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yopweidrq37o5mm2" Content-Disposition: inline In-Reply-To: <20170702072710.29988-1-net147@gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yopweidrq37o5mm2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, Jul 02, 2017 at 05:27:10PM +1000, Jonathan Liu wrote: > The documentation for drm_do_get_edid in drivers/gpu/drm/drm_edid.c state= s: > "As in the general case the DDC bus is accessible by the kernel at the I2C > level, drivers must make all reasonable efforts to expose it as an I2C > adapter and use drm_get_edid() instead of abusing this function." >=20 > Exposing the DDC bus as an I2C adapter is more beneficial as it can be us= ed > for purposes other than reading the EDID such as modifying the EDID or > using the HDMI DDC pins as an I2C bus through the I2C dev interface from > userspace (e.g. i2c-tools). >=20 > Implement this for A10s. >=20 > Signed-off-by: Jonathan Liu Thanks for your work on this, I've queued it in 3.14. It will appear in my branches and next as soon as 3.13-rc1 is out. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --yopweidrq37o5mm2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZW/JuAAoJEBx+YmzsjxAgIosQAL5cu/TZUOgNKd4U80+hF3EY 3hZw6eU2ouAyRhhuywchz7yfrVufEri1qyhBWDIwoz2idUv3n2nTM4t8mn7dpjtD aVNii56HUBlP8kEcDCSdOTa7A7tiJgcng4xRJ+d8GBSEfwSq6shfRwMuaIKJAPWM 7i28WFP0TCRtLmBGqRxbbchBGIbIIBCWQrH6Rp/ggb1goHhpkA0JzeRgt75R1apa NvWP/gI2/FCkA1Gnq9B+DQ+8GwfrrglMlNEy/+SQJc+F3wQrwBDRiUfrUdHD9j8h etG6F+CXqD0qPmAAzjbw55t1xOLnmMhTQfimxaZMDvP+9QdOuLhYM2qjrzmiO8nn r0ie6litI90QfzPTghlAMOoxXMKAvCkzkUDFmme9fqkHuF0kKpak0NjiPHGoeLXH HLVcJt/kPoe1fncaf5j1Hc04rl6AlgQszs26TfwMPXdIy/DqSQCXtGCrLc29sKJJ BmTtfw5zBu3zO0v2C4cIIdkPTHTKQZOmylYIPwDuxIOBsrwBnObVX9t7pcKBCyrx 1BfJECLq9j2zVt0y32u8nYSlbSlZCabHS8sR/RkmV5ynTMWKZKiOhUaanYC97Esa z/MUdG3TieQU86jemnhbWLV0AVXdXP2jdbQyOD+QehD8s6lmYASdIqAlOJApWYJ4 kQnv3EZluee1XwwXEfWN =kak+ -----END PGP SIGNATURE----- --yopweidrq37o5mm2-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Tue, 4 Jul 2017 21:54:22 +0200 Subject: [PATCH v8] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus In-Reply-To: <20170702072710.29988-1-net147@gmail.com> References: <20170702072710.29988-1-net147@gmail.com> Message-ID: <20170704195422.hsi4lhzlqb75gm4n@flea> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Sun, Jul 02, 2017 at 05:27:10PM +1000, Jonathan Liu wrote: > The documentation for drm_do_get_edid in drivers/gpu/drm/drm_edid.c states: > "As in the general case the DDC bus is accessible by the kernel at the I2C > level, drivers must make all reasonable efforts to expose it as an I2C > adapter and use drm_get_edid() instead of abusing this function." > > Exposing the DDC bus as an I2C adapter is more beneficial as it can be used > for purposes other than reading the EDID such as modifying the EDID or > using the HDMI DDC pins as an I2C bus through the I2C dev interface from > userspace (e.g. i2c-tools). > > Implement this for A10s. > > Signed-off-by: Jonathan Liu Thanks for your work on this, I've queued it in 3.14. It will appear in my branches and next as soon as 3.13-rc1 is out. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v8] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus Date: Tue, 4 Jul 2017 21:54:22 +0200 Message-ID: <20170704195422.hsi4lhzlqb75gm4n@flea> References: <20170702072710.29988-1-net147@gmail.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yopweidrq37o5mm2" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20170702072710.29988-1-net147-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Jonathan Liu Cc: David Airlie , Chen-Yu Tsai , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: dri-devel@lists.freedesktop.org --yopweidrq37o5mm2 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Hi, On Sun, Jul 02, 2017 at 05:27:10PM +1000, Jonathan Liu wrote: > The documentation for drm_do_get_edid in drivers/gpu/drm/drm_edid.c states: > "As in the general case the DDC bus is accessible by the kernel at the I2C > level, drivers must make all reasonable efforts to expose it as an I2C > adapter and use drm_get_edid() instead of abusing this function." > > Exposing the DDC bus as an I2C adapter is more beneficial as it can be used > for purposes other than reading the EDID such as modifying the EDID or > using the HDMI DDC pins as an I2C bus through the I2C dev interface from > userspace (e.g. i2c-tools). > > Implement this for A10s. > > Signed-off-by: Jonathan Liu Thanks for your work on this, I've queued it in 3.14. It will appear in my branches and next as soon as 3.13-rc1 is out. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --yopweidrq37o5mm2--