All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] package/kvazaar: needs C++ compiler
Date: Wed, 5 Jul 2017 01:18:24 +0200	[thread overview]
Message-ID: <20170704231524.D52F17F94D@busybox.osuosl.org> (raw)

commit: https://git.buildroot.net/buildroot/commit/?id=7e0b4a5cd0b398e21f50be4eb111a926dbac471b
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Even if there is only one CPP file src/extras/crypto.cpp which should
be disabled by --without-cryptopp, kvazaar fail to build the shared
library libkvazaar.so when no C++ compiler is available.

checking whether we are using the GNU C++ compiler... no

Fixes:
[microblazel] http://autobuild.buildroot.net/results/5d1/5d140ed95e292f73b6770a5e5be717df844e4830
[arm] http://autobuild.buildroot.net/results/c55/c55b973502b9b88643ae9fca11447b547148275d

Signed-off-by: Romain Naour <romain.naour@smile.fr>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/kvazaar/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/kvazaar/Config.in b/package/kvazaar/Config.in
index 06ab9ac..de2c6c9 100644
--- a/package/kvazaar/Config.in
+++ b/package/kvazaar/Config.in
@@ -1,10 +1,11 @@
 config BR2_PACKAGE_KVAZAAR
 	bool "kvazaar"
+	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  An open-source HEVC encoder licensed under LGPLv2.1
 
 	  https://github.com/ultravideo/kvazaar
 
-comment "kvazaar needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
+comment "kvazaar needs a toolchain w/ C++, threads"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS

                 reply	other threads:[~2017-07-04 23:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170704231524.D52F17F94D@busybox.osuosl.org \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.