From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSVr6-0004NW-Sp for qemu-devel@nongnu.org; Tue, 04 Jul 2017 17:59:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSVr3-0006AB-Rg for qemu-devel@nongnu.org; Tue, 04 Jul 2017 17:59:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49434) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dSVr3-0006A5-Le for qemu-devel@nongnu.org; Tue, 04 Jul 2017 17:59:33 -0400 Date: Wed, 5 Jul 2017 00:59:25 +0300 From: "Michael S. Tsirkin" Message-ID: <20170705005657-mutt-send-email-mst@kernel.org> References: <20170628190047.26159-1-dgilbert@redhat.com> <20170628190047.26159-26-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170628190047.26159-26-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [RFC 25/29] vhu: enable = false on get_vring_base List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, a.perevalov@samsung.com, marcandre.lureau@redhat.com, maxime.coquelin@redhat.com, quintela@redhat.com, peterx@redhat.com, lvivier@redhat.com, aarcange@redhat.com On Wed, Jun 28, 2017 at 08:00:43PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > When we receive a GET_VRING_BASE message set enable = false > to stop any new received packets modifying the ring. > > Signed-off-by: Dr. David Alan Gilbert I think I already reviewed a similar patch. Spec says: Client must only process each ring when it is started. IMHO the real fix is to fix client to check the started flag before processing the ring. > --- > contrib/libvhost-user/libvhost-user.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c > index ceddeac74f..d37052b7b0 100644 > --- a/contrib/libvhost-user/libvhost-user.c > +++ b/contrib/libvhost-user/libvhost-user.c > @@ -652,6 +652,7 @@ vu_get_vring_base_exec(VuDev *dev, VhostUserMsg *vmsg) > vmsg->size = sizeof(vmsg->payload.state); > > dev->vq[index].started = false; > + dev->vq[index].enable = false; > if (dev->iface->queue_set_started) { > dev->iface->queue_set_started(dev, index, false); > } > -- > 2.13.0