From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v10 13/20] unci: add ethtool support Date: Wed, 5 Jul 2017 12:07:44 -0700 Message-ID: <20170705120744.72b0c796@xeon-e3> References: <20170630165140.59594-1-ferruh.yigit@intel.com> <20170704161337.45926-1-ferruh.yigit@intel.com> <20170704161337.45926-14-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Bruce Richardson , Anatoly Burakov To: Ferruh Yigit Return-path: Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com [209.85.192.176]) by dpdk.org (Postfix) with ESMTP id 28FD6378B for ; Wed, 5 Jul 2017 21:07:47 +0200 (CEST) Received: by mail-pf0-f176.google.com with SMTP id q86so134031365pfl.3 for ; Wed, 05 Jul 2017 12:07:47 -0700 (PDT) In-Reply-To: <20170704161337.45926-14-ferruh.yigit@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 4 Jul 2017 17:13:30 +0100 Ferruh Yigit wrote: > +static void unci_get_drvinfo(struct net_device *dev, > + struct ethtool_drvinfo *info) > +{ > + int ret; > + > + ret = unci_nl_exec(info->cmd, dev, NULL, 0, > + info, sizeof(struct ethtool_drvinfo)); > + if (ret < 0) > + memset(info, 0, sizeof(struct ethtool_drvinfo)); > +} drvinfo is already zero'd in net/core/ethtool.c