From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id B2382C49 for ; Wed, 5 Jul 2017 15:33:00 +0000 (UTC) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id EC383171 for ; Wed, 5 Jul 2017 15:32:59 +0000 (UTC) Date: Wed, 5 Jul 2017 17:32:59 +0200 From: Greg KH To: Guenter Roeck Message-ID: <20170705153259.GA7265@kroah.com> References: <576cea07-770a-4864-c3f5-0832ff211e94@leemhuis.info> <20170703123025.7479702e@gandalf.local.home> <20170705084528.67499f8c@gandalf.local.home> <4080ecc7-1aa8-2940-f230-1b79d656cdb4@redhat.com> <20170705092757.63dc2328@gandalf.local.home> <20170705140607.GA30187@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: ksummit-discuss@lists.linuxfoundation.org, Carlos O'Donell , linux-api@vger.kernel.org, Thorsten Leemhuis , Shuah Khan Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jul 05, 2017 at 08:16:33AM -0700, Guenter Roeck wrote: > If we start shaming people for not providing unit tests, all we'll accomplish is > that people will stop providing bug fixes. Yes, this is the key! Steven, just look at everything marked with a "Fixes:" or "stable@" tag from 4.12-rc1..4.12 and try to determine how you would write a test for the majority of them. Yes, for some subsystems this can work (look at xfstests as one great example for filesystems, same for the i915 tests), but for the majority of the kernel, at this point in time, it doesn't make sense. So take Carlos's advice, start small, do it for your subsystem if you don't touch hardware (easy peasy, right?), and let's see how it goes, and see if we have the infrastructure to do it even today. Right now, kselftests is finally getting a unified output format, which is great, it shows that people are starting to use and rely on it. What else will we need to make this more widely used, we don't know yet... thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking Date: Wed, 5 Jul 2017 17:32:59 +0200 Message-ID: <20170705153259.GA7265@kroah.com> References: <576cea07-770a-4864-c3f5-0832ff211e94@leemhuis.info> <20170703123025.7479702e@gandalf.local.home> <20170705084528.67499f8c@gandalf.local.home> <4080ecc7-1aa8-2940-f230-1b79d656cdb4@redhat.com> <20170705092757.63dc2328@gandalf.local.home> <20170705140607.GA30187@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Guenter Roeck Cc: Steven Rostedt , Carlos O'Donell , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thorsten Leemhuis , ksummit-discuss-cunTk1MwBs98uUxBSJOaYoYkZiVZrdSR2LY78lusg7I@public.gmane.org, Shuah Khan List-Id: linux-api@vger.kernel.org On Wed, Jul 05, 2017 at 08:16:33AM -0700, Guenter Roeck wrote: > If we start shaming people for not providing unit tests, all we'll accomplish is > that people will stop providing bug fixes. Yes, this is the key! Steven, just look at everything marked with a "Fixes:" or "stable@" tag from 4.12-rc1..4.12 and try to determine how you would write a test for the majority of them. Yes, for some subsystems this can work (look at xfstests as one great example for filesystems, same for the i915 tests), but for the majority of the kernel, at this point in time, it doesn't make sense. So take Carlos's advice, start small, do it for your subsystem if you don't touch hardware (easy peasy, right?), and let's see how it goes, and see if we have the infrastructure to do it even today. Right now, kselftests is finally getting a unified output format, which is great, it shows that people are starting to use and rely on it. What else will we need to make this more widely used, we don't know yet... thanks, greg k-h