From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752503AbdGFRSC (ORCPT ); Thu, 6 Jul 2017 13:18:02 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:34193 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbdGFRSA (ORCPT ); Thu, 6 Jul 2017 13:18:00 -0400 Date: Thu, 6 Jul 2017 12:17:57 -0500 From: Rob Herring To: David Wu Cc: thierry.reding@gmail.com, heiko@sntech.de, boris.brezillon@free-electrons.com, catalin.marinas@arm.com, briannorris@chromium.org, dianders@chromium.org, mark.rutland@arm.com, huangtao@rock-chips.com, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328 Message-ID: <20170706171757.qmnvmdyjuj77tt27@rob-hp-laptop> References: <1498739271-27431-1-git-send-email-david.wu@rock-chips.com> <1498739271-27431-5-git-send-email-david.wu@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498739271-27431-5-git-send-email-david.wu@rock-chips.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 29, 2017 at 08:27:50PM +0800, David Wu wrote: > The rk3328 soc supports atomic update, we could lock the configuration > of period and duty at first, after unlock is configured, the period and > duty are effective at the same time. > > If the polarity, period and duty need to be configured together, > the way for atomic update is "configure lock and old polarity" -> > "configure period and duty" -> "configure unlock and new polarity". > > Signed-off-by: David Wu > --- > .../devicetree/bindings/pwm/pwm-rockchip.txt | 1 + The subject is a bit misleading as you are adding support for a new version of the IP. Otherwise, Acked-by: Rob Herring > drivers/pwm/pwm-rockchip.c | 50 +++++++++++++++++++--- > 2 files changed, 46 insertions(+), 5 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Thu, 6 Jul 2017 12:17:57 -0500 Subject: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328 In-Reply-To: <1498739271-27431-5-git-send-email-david.wu@rock-chips.com> References: <1498739271-27431-1-git-send-email-david.wu@rock-chips.com> <1498739271-27431-5-git-send-email-david.wu@rock-chips.com> Message-ID: <20170706171757.qmnvmdyjuj77tt27@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jun 29, 2017 at 08:27:50PM +0800, David Wu wrote: > The rk3328 soc supports atomic update, we could lock the configuration > of period and duty at first, after unlock is configured, the period and > duty are effective at the same time. > > If the polarity, period and duty need to be configured together, > the way for atomic update is "configure lock and old polarity" -> > "configure period and duty" -> "configure unlock and new polarity". > > Signed-off-by: David Wu > --- > .../devicetree/bindings/pwm/pwm-rockchip.txt | 1 + The subject is a bit misleading as you are adding support for a new version of the IP. Otherwise, Acked-by: Rob Herring > drivers/pwm/pwm-rockchip.c | 50 +++++++++++++++++++--- > 2 files changed, 46 insertions(+), 5 deletions(-)