From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: Re: [PATCH v1 3/9] usb: chipidea: Add support for Tegra20/30/114/124 Date: Fri, 7 Jul 2017 09:10:40 +0800 Message-ID: <20170707011040.GA21909@b29397-desktop> References: <9e0127ea9b580e1af334c4c3bcb8b3c0705614ea.1499273075.git.digetx@gmail.com> <20170706012310.GC24420@b29397-desktop> <59e943b8-8771-0b1e-36fa-babd5e52a6d5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <59e943b8-8771-0b1e-36fa-babd5e52a6d5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: Thierry Reding , Felipe Balbi , Greg Kroah-Hartman , Peter Chen , Jonathan Hunter , Marc Dietrich , Nicolas Chauvet , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thierry Reding List-Id: linux-tegra@vger.kernel.org On Thu, Jul 06, 2017 at 01:09:32PM +0300, Dmitry Osipenko wrote: > On 06.07.2017 04:23, Peter Chen wrote: > > On Wed, Jul 05, 2017 at 08:19:52PM +0300, Dmitry Osipenko wrote: > >> + /* setup and register ChipIdea HDRC device */ > >> + udc->data.name = "tegra-udc"; > >> + udc->data.capoffset = DEF_CAPOFFSET; > >> + udc->data.flags = 0; > >> + udc->data.usb_phy = udc->phy; > >> + > >> + /* setup device specific quirks */ > >> + soc = id->data; > >> + > >> + if (!soc->supports_unaligned_dma) > >> + udc->data.flags |= CI_HDRC_REQUIRES_ALIGNED_DMA; > >> + > >> + /* power on UDC controller */ > >> + usb_phy_set_suspend(udc->phy, 0); > > > > Why above is needed? The chipidea core will do usb_phy_init for power > > on. > > > > It is needed because Tegra's USB PHY driver doesn't hook up .init() of the > struct usb_phy and the power management is handled by set_suspend(). > Ok, please comment it since it is strange that initialize phy at .set_suspend API, after that, you can add my Ack for this patch. -- Best Regards, Peter Chen