From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTRcH-0004cA-8H for qemu-devel@nongnu.org; Fri, 07 Jul 2017 07:40:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTRcE-0002rv-4F for qemu-devel@nongnu.org; Fri, 07 Jul 2017 07:40:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33812) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dTRcD-0002rj-Tt for qemu-devel@nongnu.org; Fri, 07 Jul 2017 07:40:06 -0400 Date: Fri, 7 Jul 2017 12:39:51 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170707113951.GB2451@work-vm> References: <20170628190047.26159-1-dgilbert@redhat.com> <20170628190047.26159-30-dgilbert@redhat.com> <09cc072b-68c1-5212-c9ad-8cb0cf64a892@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09cc072b-68c1-5212-c9ad-8cb0cf64a892@redhat.com> Subject: Re: [Qemu-devel] [RFC 29/29] vhost-user: Claim support for postcopy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Maxime Coquelin Cc: qemu-devel@nongnu.org, a.perevalov@samsung.com, marcandre.lureau@redhat.com, mst@redhat.com, quintela@redhat.com, peterx@redhat.com, lvivier@redhat.com, aarcange@redhat.com * Maxime Coquelin (maxime.coquelin@redhat.com) wrote: > > > On 06/28/2017 09:00 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Tell QEMU we understand the protocol features needed for postcopy. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > contrib/libvhost-user/libvhost-user.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c > > index c1716d1a62..1c46aecfb3 100644 > > --- a/contrib/libvhost-user/libvhost-user.c > > +++ b/contrib/libvhost-user/libvhost-user.c > > @@ -797,7 +797,8 @@ vu_set_vring_err_exec(VuDev *dev, VhostUserMsg *vmsg) > > static bool > > vu_get_protocol_features_exec(VuDev *dev, VhostUserMsg *vmsg) > > { > > - uint64_t features = 1ULL << VHOST_USER_PROTOCOL_F_LOG_SHMFD; > > + uint64_t features = 1ULL << VHOST_USER_PROTOCOL_F_LOG_SHMFD | > > + 1ULL << VHOST_USER_PROTOCOL_F_POSTCOPY; > > Maybe advertising VHOST_USER_PROTOCOL_F_POSTCOPY could be done only > if userfaultfd syscall is supported? Done. Dave > > if (dev->iface->get_protocol_features) { > > features |= dev->iface->get_protocol_features(dev); > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK