From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH 0/2] virtio fix false offload claims Date: Sat, 8 Jul 2017 11:12:22 +0800 Message-ID: <20170708031222.GA11626@yliu-home> References: <20170707195250.22259-1-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: maxime.coquelin@redhat.com, dev@dpdk.org, stable@dpdk.org To: Stephen Hemminger Return-path: Received: from mail-pf0-f172.google.com (mail-pf0-f172.google.com [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id 9DE972C8 for ; Sat, 8 Jul 2017 05:12:30 +0200 (CEST) Received: by mail-pf0-f172.google.com with SMTP id e7so25213504pfk.0 for ; Fri, 07 Jul 2017 20:12:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170707195250.22259-1-stephen@networkplumber.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jul 07, 2017 at 12:52:48PM -0700, Stephen Hemminger wrote: > While doing code for Hyper-V, noticed that the virtio driver was > confused about receive versus transmit offloads. The virtio > checksum offload is L4 (TCP/UDP) only, not IPv4. Also, TSO > and LRO are not the same. > > This may break some program that was assuming it was getting offloads > that it wasn't. Applied to dpdk-next-virtio. And I think they should be backported to stable releases, thus, Cc: stable@dpdk.org Thanks. --yliu > > Stephen Hemminger (2): > virtio: don't falsely claim to do IP checksum > virtio: don't claim to support LRO > > drivers/net/virtio/virtio_ethdev.c | 30 +++++------------------------- > 1 file changed, 5 insertions(+), 25 deletions(-) > > -- > 2.11.0