All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: tglx@linutronix.de, mingo@kernel.org, anna-maria@linutronix.de,
	boris.ostrovsky@oracle.com, rcochran@linutronix.de,
	torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: cpu: hotplug: constify attribute_group structures.
Date: Mon, 10 Jul 2017 09:14:42 +0200	[thread overview]
Message-ID: <20170710071442.pvfbfknsn5hmjqk4@linutronix.de> (raw)
In-Reply-To: <f9079e94e12b36d245e7adbf67d312bc5d0250c6.1498737970.git.arvind.yadav.cs@gmail.com>

On 2017-06-29 17:40:47 [+0530], Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   12582	  15361	     20	  27963	   6d3b	kernel/cpu.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   12710	  15265	     20	  27995	   6d5b	kernel/cpu.o

While there does not seem to be anything wrong with it, why did the file
grow after the patch was applied?

> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Sebastian

  parent reply	other threads:[~2017-07-10  7:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29 12:10 [PATCH] kernel: cpu: hotplug: constify attribute_group structures Arvind Yadav
2017-06-30 13:10 ` [tip:smp/hotplug] cpu/hotplug: Constify " tip-bot for Arvind Yadav
2017-07-10  7:14 ` Sebastian Andrzej Siewior [this message]
2017-07-10  7:29   ` [PATCH] kernel: cpu: hotplug: constify " Arvind Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170710071442.pvfbfknsn5hmjqk4@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=anna-maria@linutronix.de \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rcochran@linutronix.de \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.