From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH 1/2 net] ptp: fix error codes in ptp_clock_register() Date: Mon, 10 Jul 2017 12:38:16 +0300 Message-ID: <20170710093816.wz5uiqoyilgxmgh3@mwanda> References: <20170710071137.ui2fhjkqzjqhkopz@mwanda> <20170710092103.vnanagwpimk43zoz@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ganesh Goudar , Atul Gupta , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Richard Cochran Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:18291 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751835AbdGJJia (ORCPT ); Mon, 10 Jul 2017 05:38:30 -0400 Content-Disposition: inline In-Reply-To: <20170710092103.vnanagwpimk43zoz@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jul 10, 2017 at 11:21:03AM +0200, Richard Cochran wrote: > On Mon, Jul 10, 2017 at 10:11:37AM +0300, Dan Carpenter wrote: > > The ptp_clock_register() function returns NULL when it's #ifdefed out > > because CONFIG_PTP_1588_CLOCK is disabled. Otherwise, it's intended to > > return error pointers. Unfortunately, there are a couple paths where we > > forget to set the error code. It means that we could result in NULL > > pointer dereferences in the callers. > > > > Fixes: d94ba80ebbea ("ptp: Added a brand new class driver for ptp clocks.") > > This "Fixes" tag references the wrong commit. Please correct it. > There were two buggy commits so I chose the ealier one. The other buggy commit is 85a66e550195 ("ptp: create "pins" together with the rest of attributes"). I should have CC'd Dmitry as well. I can resend. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Mon, 10 Jul 2017 09:38:16 +0000 Subject: Re: [PATCH 1/2 net] ptp: fix error codes in ptp_clock_register() Message-Id: <20170710093816.wz5uiqoyilgxmgh3@mwanda> List-Id: References: <20170710071137.ui2fhjkqzjqhkopz@mwanda> <20170710092103.vnanagwpimk43zoz@localhost.localdomain> In-Reply-To: <20170710092103.vnanagwpimk43zoz@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Richard Cochran Cc: Ganesh Goudar , Atul Gupta , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org On Mon, Jul 10, 2017 at 11:21:03AM +0200, Richard Cochran wrote: > On Mon, Jul 10, 2017 at 10:11:37AM +0300, Dan Carpenter wrote: > > The ptp_clock_register() function returns NULL when it's #ifdefed out > > because CONFIG_PTP_1588_CLOCK is disabled. Otherwise, it's intended to > > return error pointers. Unfortunately, there are a couple paths where we > > forget to set the error code. It means that we could result in NULL > > pointer dereferences in the callers. > > > > Fixes: d94ba80ebbea ("ptp: Added a brand new class driver for ptp clocks.") > > This "Fixes" tag references the wrong commit. Please correct it. > There were two buggy commits so I chose the ealier one. The other buggy commit is 85a66e550195 ("ptp: create "pins" together with the rest of attributes"). I should have CC'd Dmitry as well. I can resend. regards, dan carpenter