All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Chang <mchang@suse.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: "Knippers, Linda" <linda.knippers@hpe.com>,
	"arvidjaar@gmail.com" <arvidjaar@gmail.com>,
	"phcoder@gmail.com" <phcoder@gmail.com>,
	"Chang, Clay (HPS OE-Linux TDC)" <clayc@hpe.com>,
	"Ruan, Michael (HPS OE-Linux/VMware TDC)" <michael.ruan@hpe.com>
Subject: Re: [PATCH v2 0/9] Add UEFI HTTP Boot support for IPv4 and IPv6
Date: Mon, 10 Jul 2017 18:10:34 +0800	[thread overview]
Message-ID: <20170710101034.GE26571@linux-9gqx.suse.de> (raw)
In-Reply-To: <DF4PR84MB010625ECFDF493D2B8AD4559ABD50@DF4PR84MB0106.NAMPRD84.PROD.OUTLOOK.COM>

On Thu, Jul 06, 2017 at 06:52:02AM +0000, Lin, Keng-Yu wrote:
> > Hi Keng-Yu,
> >
> > Sorry for late reply but I clearing my backlog after long vacation.
> >
> >
> > Thank you for doing the work. Unfortunately it is too late to put it into 2.02 release (I hope it will happen at the end of February or at beginning of March). I am adding this patch set to review > after release.
> > Please be patient.
> >
> > Daniel
> 
> Hi Daniel:
>   Wonder if there is any chance to get this patchset moving on.
>   This patchset was well tested on both Qemu/EDK2 and some real HPE ProLiant Gen10 machines.
>   (check the cover letter for more details.)

How many test case did you perform on this patch. More specifically, did you
verify how does it work with existing network commands

 https://www.gnu.org/software/grub/manual/grub.html#Networking-commands

And also environment variables related to network

  https://www.gnu.org/software/grub/manual/grub.html#Network

I think the patch is good at running grub booted directly by UEFI http load
file protocol, assuming the UEFI Handle has configured network protocol down
the road before handing over to grub. But that may not satisfied the user as
they get used to have more than that already.
 
Practically grub can work out more (sophisticated) scenario by exercising the
network commands to configure the network interface one way or the other, and
obviously the patch did not route the same commands to UEFI network stack,
which is regarded as functional regression as it did not apply on UEFI
protocol.

Thanks,
Michael

> 	
>   Let me know if there is anything further I can help. :-)
> 
>   Thanks,
> -kengyu
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel


  reply	other threads:[~2017-07-10 10:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-23  8:54 [PATCH v2 0/9] Add UEFI HTTP Boot support for IPv4 and IPv6 Keng-Yu Lin
2016-12-23  8:54 ` [PATCH 1/9] strtoull: Fix behaviour on chars between '9' and 'a' Keng-Yu Lin
2016-12-23  8:54 ` [PATCH 2/9] net: read bracketed ipv6 addrs and port numbers Keng-Yu Lin
2016-12-23  8:54 ` [PATCH v2 3/9] Add default port in grub_net_app_protocol Keng-Yu Lin
2016-12-23  8:54 ` [PATCH 4/9] bootp: New net_bootp6 command Keng-Yu Lin
2016-12-23  8:54 ` [PATCH 5/9] efinet: UEFI IPv6 PXE support Keng-Yu Lin
2016-12-23  8:54 ` [PATCH 6/9] grub.texi: Add net_bootp6 doument Keng-Yu Lin
2016-12-23  8:54 ` [PATCH 7/9] bootp: Add processing DHCPACK packet from HTTP Boot Keng-Yu Lin
2016-12-23  8:54 ` [PATCH 8/9] efinet: Setting network from UEFI device path Keng-Yu Lin
2016-12-23  8:54 ` [PATCH 9/9] efinet: Setting DNS server from UEFI protocol Keng-Yu Lin
2017-01-16  9:07 ` [PATCH v2 0/9] Add UEFI HTTP Boot support for IPv4 and IPv6 Lin, Keng-Yu (HPS OE-Linux TDC)
2017-01-16 10:12   ` Daniel Kiper
2017-07-06  6:52     ` Lin, Keng-Yu
2017-07-10 10:10       ` Michael Chang [this message]
2017-07-11  7:39         ` Lin, Keng-Yu
2017-07-11  9:48           ` Michael Chang
2017-07-10 20:41       ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170710101034.GE26571@linux-9gqx.suse.de \
    --to=mchang@suse.com \
    --cc=arvidjaar@gmail.com \
    --cc=clayc@hpe.com \
    --cc=grub-devel@gnu.org \
    --cc=linda.knippers@hpe.com \
    --cc=michael.ruan@hpe.com \
    --cc=phcoder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.