All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvmem: include linux/err.h from header
Date: Mon, 10 Jul 2017 14:28:43 +0200	[thread overview]
Message-ID: <20170710122843.dxxcr2sdsnxzvf2y@piout.net> (raw)
In-Reply-To: <CAK8P3a3LaeA6Ycw_FryAUBOeJ3PCH36u6XLw8Bgf6+2o3TO52g@mail.gmail.com>

On 10/07/2017 at 14:10:03 +0200, Arnd Bergmann wrote:
> On Mon, Jul 10, 2017 at 1:33 PM, Srinivas Kandagatla
> <srinivas.kandagatla@linaro.org> wrote:
> >
> >
> > On 10/07/17 12:22, Arnd Bergmann wrote:
> >>
> >> The new support for nvmem devices from the rtc layer caused a build
> >> error in some configurations:
> >>
> >> include/linux/nvmem-provider.h: In function 'nvmem_register':
> >> include/linux/nvmem-provider.h:51:9: error: implicit declaration of
> >> function 'ERR_PTR' [-Werror=implicit-function-declaration]
> >>
> >> This adds the missing include to ensure we can always include
> >> the header.
> >>
> >> Fixes: 697e5a47aa12 ("rtc: add generic nvmem support")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> ---
> >> I'd suggest adding this patch in the rtc tree on top of the
> >> nvmem support there.
> >
> >
> > Thanks for the patch, we would need similar patch for
> > include/linux/nvmem-consumer.h too.
> 
> Makes sense, yes. Can you do that for 4.14? My patch for now is
> needed to fix a build regression in the rtc-next tree that I
> assume will otherwise make it into the 4.13 release.
> 

Yes, I'm planning to send my PR soon.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2017-07-10 12:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10 11:22 [PATCH] nvmem: include linux/err.h from header Arnd Bergmann
2017-07-10 11:33 ` Srinivas Kandagatla
2017-07-10 12:10   ` Arnd Bergmann
2017-07-10 12:22     ` Srinivas Kandagatla
2017-07-10 12:28     ` Alexandre Belloni [this message]
2017-07-10 12:28 ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170710122843.dxxcr2sdsnxzvf2y@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.