From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754738AbdGJScz (ORCPT ); Mon, 10 Jul 2017 14:32:55 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45534 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753298AbdGJScx (ORCPT ); Mon, 10 Jul 2017 14:32:53 -0400 Date: Mon, 10 Jul 2017 19:32:44 +0100 From: Mark Brown To: Aravind Thokala Cc: Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-ID: <20170710183244.hds7lyoxoymiza7r@sirena.org.uk> References: <1498579630-10109-1-git-send-email-aravind.thk@gmail.com> <20170628184507.tnl7jc4wvtt5op5q@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2x4fmnuk72u5bpbp" Content-Disposition: inline In-Reply-To: X-Cookie: I'm wearing PAMPERS!! User-Agent: NeoMutt/20170609 (1.8.3) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2x4fmnuk72u5bpbp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 30, 2017 at 11:08:15PM +0530, Aravind Thokala wrote: > Hello Mark, Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed. > These warnings looked straightforward for me so I've fixed those and > sent the patch. > Kindly let me know if you want to record the warnings in the patch so > that I could send v2 patch as soon as possible. It's not just a case of quoting the warnings, it's a case of explaining what your patch changes which usually requires more than just quoting the warning. --2x4fmnuk72u5bpbp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlljyEsACgkQJNaLcl1U h9CEiQf/fbfRCjLq8vZYurKZrTHn0maDAoBhdZoMFFJ1HN0gzPKIggW6eWm9Zook 4hlbaa4cYxnmnDvsjKe5V71yf7ez3Qtz2bXhctBDvklsB+TQ0ZyoqFSplRoCUW1i +0OuLC9nhjbT5LwMXEqJuAl9bxbhWi9KBvlnuQXUld6el3D9kQp/tRsw9+j6zQ2Y HoQWrBRZVYlLw6mgicY5ii0M5fai1MIVFh0ehGDFzClXAN3HtpQ6/JWyuLQ88PXZ Fez/GTP5h2Vdgl3TdOh5sDEGQ25e/KktjWFLdiaP1k5SsSmbSBLKIhDOfXzL4tUY 9R0jiomsYRjwAhF5M9UzrP6RLOx1eQ== =9f22 -----END PGP SIGNATURE----- --2x4fmnuk72u5bpbp-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@kernel.org (Mark Brown) Date: Mon, 10 Jul 2017 19:32:44 +0100 Subject: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings In-Reply-To: References: <1498579630-10109-1-git-send-email-aravind.thk@gmail.com> <20170628184507.tnl7jc4wvtt5op5q@sirena.org.uk> Message-ID: <20170710183244.hds7lyoxoymiza7r@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jun 30, 2017 at 11:08:15PM +0530, Aravind Thokala wrote: > Hello Mark, Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed. > These warnings looked straightforward for me so I've fixed those and > sent the patch. > Kindly let me know if you want to record the warnings in the patch so > that I could send v2 patch as soon as possible. It's not just a case of quoting the warnings, it's a case of explaining what your patch changes which usually requires more than just quoting the warning. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: