From mboxrd@z Thu Jan  1 00:00:00 1970
From: keith.busch@intel.com (Keith Busch)
Date: Mon, 10 Jul 2017 18:57:30 -0400
Subject: [PATCH 2/7] nvme/fc: Fix admin queue depth setup
In-Reply-To: <aef1f200-336f-fdf4-36bc-fe13bfd67474@grimberg.me>
References: <1499444581-28268-1-git-send-email-keith.busch@intel.com>
 <1499444581-28268-3-git-send-email-keith.busch@intel.com>
 <aef1f200-336f-fdf4-36bc-fe13bfd67474@grimberg.me>
Message-ID: <20170710225730.GB13671@localhost.localdomain>

On Mon, Jul 10, 2017@08:59:02AM +0300, Sagi Grimberg wrote:
> > The NVME_FC_AQ_BLKMQ_DEPTH is one less than what we actually want the
> > admin queue's depth to be since it subtracts the AEN entry.
> > 
> > We also need to subtract 1 from the blk-mq depth to always leave an
> > empty queue entry, and to not collide command id with the AEN request.
> > 
> > Signed-off-by: Keith Busch <keith.busch at intel.com>
> 
> nvme-loop needs the same patch.

Yeah, it looks like it does, though it's inadvertently fixed in patch
4. In truth, patch 4 makes this one unnecessary for fc too, but I didn't
want to change the q-depth and centralize its definition in a single
patch. I'll spin a new version with the loop fix in the series, as well
as Christoph's suggestions.