From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v4 4/7] service cores: add unit tests
Date: Tue, 11 Jul 2017 13:42:08 +0530
Message-ID: <20170711081207.GA29792@jerin>
References: <1498735421-100164-1-git-send-email-harry.van.haaren@intel.com>
 <1499445667-32588-1-git-send-email-harry.van.haaren@intel.com>
 <1499445667-32588-5-git-send-email-harry.van.haaren@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, thomas@monjalon.net, keith.wiles@intel.com,
 bruce.richardson@intel.com
To: Harry van Haaren <harry.van.haaren@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam03on0042.outbound.protection.outlook.com [104.47.40.42])
 by dpdk.org (Postfix) with ESMTP id 7C7C1376C
 for <dev@dpdk.org>; Tue, 11 Jul 2017 10:12:32 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1499445667-32588-5-git-send-email-harry.van.haaren@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Fri, 7 Jul 2017 17:41:04 +0100
> From: Harry van Haaren <harry.van.haaren@intel.com>
> To: dev@dpdk.org
> CC: thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
>  keith.wiles@intel.com, bruce.richardson@intel.com, Harry van Haaren
>  <harry.van.haaren@intel.com>
> Subject: [PATCH v4 4/7] service cores: add unit tests
> X-Mailer: git-send-email 2.7.4
> 
> Add a bunch of unit tests, to ensure that the service
> core functions are operating as expected.
> 
> As part of these tests a dummy service is registered which
> allows identifying if a service callback has been invoked
> by using the CPU tick counter. This allows identifying if
> functions to start and stop service lcores are actually having
> effect.
> 
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
> ---
> 
> v4:
> - Remove static slcore_id, make service-core choice dynamic (Jerin)
> - Use lcore_get_next() to acquire service cores (Jerin)
> - Improve unit test to ensure app can remote_launc() on a core that
>   previously served as a service-core (verifies ROLE_RTE is set) (Jerin)

IMO, it has the unit testcases for every API now.

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>