All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "Emilio G. Cota" <cota@braap.org>,
	"Laurent Desnogues" <laurent.desnogues@gmail.com>,
	"Richard Henderson" <rth@twiddle.net>,
	qemu-devel@nongnu.org, "Lluís Vilanova" <vilanova@ac.upc.edu>
Subject: Re: [Qemu-devel] [PATCH v9 0/7] trace: Optimize per-vCPU TCG tracing states
Date: Tue, 11 Jul 2017 11:55:00 +0100	[thread overview]
Message-ID: <20170711105500.GQ17792@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170710120744.GC14195@stefanha-x1.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1982 bytes --]

On Mon, Jul 10, 2017 at 01:07:44PM +0100, Stefan Hajnoczi wrote:
> On Mon, Jun 26, 2017 at 06:04:34PM -0400, Emilio G. Cota wrote:
> > v8: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg02335.html
> > 
> > Changes from v8:
> > 
> > - Rebased on top of the current tracing tree -- the one that includes
> >   Lluis' fix (2c321e3c486).
> > - Added Lluis' R-b tag.
> > - Added perf numbers in the commit log of the last patch (tl;dr: no overhead).
> > 
> > Thanks,
> > 
> > 		Emilio
> > 
> > PS. How to quickly get some linux-user perf numbers:
> > 
> > I used dbt-bench[1] for a before/after comparison. I added a script to that
> > repo (breakdown.pl, see below) to make it play well with barchart[2].
> > Obtaining a comparison bar chart is quite simple:
> > 
> > 1. Generate one dbt-bench output file per QEMU checkout, e.g.:
> >   $ git checkout orig && make
> >   [ orig == "before"; new == "after" ]
> >   $ ./dbt-bench.pl /path/to/qemu/build/qemu-x86_64 > orig.out
> >   [ then do the same with orig-disabled, new, etc.]
> >   [...]
> >   $ ls *.out
> >   new-disabled.out  new.out  orig-enabled.out  orig.out
> > 
> > 2. Call dbt-bench's breakdown.pl script with the --barchart option, then
> >   pipe the output to barchart, and finally pipe to gnuplot:
> >   $ ./breakdown.pl --barchart orig.out orig-enabled.out new.out new-disabled.out \
> >     | ../barchart/barchart.pl --extra-gnuplot='set term dumb 140 30' \
> >          --extra-gnuplot='set title "NBench score; higher is better"' \
> >     | gnuplot
> > 
> > Note that barchart is just a front-end for gnuplot >=5, so any valid term will
> > work (e.g. 'set term pngcairo size 1200,500').
> > 
> > [1] https://github.com/cota/dbt-bench
> > [2] https://github.com/cota/barchart
> > 
> 
> Thanks, applied to my tracing tree:
> https://github.com/stefanha/qemu/commits/tracing

By the way, I applied your most recent version of this series today :).

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  reply	other threads:[~2017-07-11 10:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-26 22:04 [Qemu-devel] [PATCH v9 0/7] trace: Optimize per-vCPU TCG tracing states Emilio G. Cota
2017-06-26 22:04 ` [Qemu-devel] [PATCH 1/7] exec: [tcg] Refactor flush of per-CPU virtual TB cache Emilio G. Cota
2017-06-26 22:04 ` [Qemu-devel] [PATCH 2/7] cpu: allocate cpu->trace_dstate in place Emilio G. Cota
2017-06-26 22:04 ` [Qemu-devel] [PATCH 3/7] trace: [tcg] Delay changes to dynamic state when translating Emilio G. Cota
2017-06-26 22:04 ` [Qemu-devel] [PATCH 4/7] exec: [tcg] Use different TBs according to the vCPU's dynamic tracing state Emilio G. Cota
2017-06-26 22:04 ` [Qemu-devel] [PATCH 5/7] trace: [tcg] Do not generate TCG code to trace dinamically-disabled events Emilio G. Cota
2017-06-26 22:04 ` [Qemu-devel] [PATCH 6/7] trace: [tcg, trivial] Re-align generated code Emilio G. Cota
2017-06-26 22:04 ` [Qemu-devel] [PATCH 7/7] trace: Statically enable all TCG guest events Emilio G. Cota
2017-07-10 12:07 ` [Qemu-devel] [PATCH v9 0/7] trace: Optimize per-vCPU TCG tracing states Stefan Hajnoczi
2017-07-11 10:55   ` Stefan Hajnoczi [this message]
2017-07-11 12:35   ` Lluís Vilanova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170711105500.GQ17792@stefanha-x1.localdomain \
    --to=stefanha@gmail.com \
    --cc=cota@braap.org \
    --cc=laurent.desnogues@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    --cc=vilanova@ac.upc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.