From: Johannes Weiner <hannes@cmpxchg.org> To: Michal Hocko <mhocko@kernel.org> Cc: Andrew Morton <akpm@linux-foundation.org>, Cristopher Lameter <cl@linux.com>, Vlastimil Babka <vbabka@suse.cz>, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] vmemmap, memory_hotplug: fallback to base pages for vmmap Date: Tue, 11 Jul 2017 17:45:41 -0400 [thread overview] Message-ID: <20170711214541.GA11141@cmpxchg.org> (raw) In-Reply-To: <20170711212544.GA25122@dhcp22.suse.cz> On Tue, Jul 11, 2017 at 11:25:45PM +0200, Michal Hocko wrote: > On Tue 11-07-17 13:26:23, Johannes Weiner wrote: > > Hi Michael, > > > > On Tue, Jul 11, 2017 at 04:25:58PM +0200, Michal Hocko wrote: > > > Ohh, scratch that. The patch is bogus. I have completely missed that > > > vmemmap_populate_hugepages already falls back to > > > vmemmap_populate_basepages. I have to revisit the bug report I have > > > received to see what happened apart from the allocation warning. Maybe > > > we just want to silent that warning. > > > > Yep, this should be fixed in 8e2cdbcb86b0 ("x86-64: fall back to > > regular page vmemmap on allocation failure"). > > > > I figure it's good to keep some sort of warning there, though, as it > > could have performance implications when we fall back to base pages. > > Yeah, but I am not really sure the allocation warning is the right thing > here because it is just too verbose. If you consider that we will get > this warning for each memory section (128MB or 2GB)... I guess the > existing > pr_warn_once("vmemmap: falling back to regular page backing\n"); > > or maybe make it pr_warn should be enough. What do you think? It could be useful to dump the memory context at least once, to 1) let the user know we're falling back but also 2) to get the default report we split out anytime we fail in a low-memory situation - in case there is a problem with the MM subsystem. Maybe something along the lines of this? (totally untested) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index 95651dc58e09..d03c8f244e5b 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -1302,7 +1302,6 @@ static int __meminit vmemmap_populate_hugepages(unsigned long start, vmemmap_verify((pte_t *)pmd, node, addr, next); continue; } - pr_warn_once("vmemmap: falling back to regular page backing\n"); if (vmemmap_populate_basepages(addr, next, node)) return -ENOMEM; } diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index a56c3989f773..efd3f48c667c 100644 --- a/mm/sparse-vmemmap.c +++ b/mm/sparse-vmemmap.c @@ -52,18 +52,24 @@ void * __meminit vmemmap_alloc_block(unsigned long size, int node) { /* If the main allocator is up use that, fallback to bootmem. */ if (slab_is_available()) { + unsigned int order; + static int warned; struct page *page; + gfp_t gfp_mask; + order = get_order(size); + gfp_mask = GFP_KERNEL|__GFP_ZERO|__GFP_REPEAT|__GFP_NOWARN; if (node_state(node, N_HIGH_MEMORY)) - page = alloc_pages_node( - node, GFP_KERNEL | __GFP_ZERO | __GFP_REPEAT, - get_order(size)); + page = alloc_pages_node(node, gfp_mask, size); else - page = alloc_pages( - GFP_KERNEL | __GFP_ZERO | __GFP_REPEAT, - get_order(size)); + page = alloc_pages(gfp_mask, size); if (page) return page_address(page); + if (!warned) { + warn_alloc(gfp_mask, NULL, + "vmemmap alloc failure: order:%u", order); + warned = 1; + } return NULL; } else return __earlyonly_bootmem_alloc(node, size, size,
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org> To: Michal Hocko <mhocko@kernel.org> Cc: Andrew Morton <akpm@linux-foundation.org>, Cristopher Lameter <cl@linux.com>, Vlastimil Babka <vbabka@suse.cz>, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] vmemmap, memory_hotplug: fallback to base pages for vmmap Date: Tue, 11 Jul 2017 17:45:41 -0400 [thread overview] Message-ID: <20170711214541.GA11141@cmpxchg.org> (raw) In-Reply-To: <20170711212544.GA25122@dhcp22.suse.cz> On Tue, Jul 11, 2017 at 11:25:45PM +0200, Michal Hocko wrote: > On Tue 11-07-17 13:26:23, Johannes Weiner wrote: > > Hi Michael, > > > > On Tue, Jul 11, 2017 at 04:25:58PM +0200, Michal Hocko wrote: > > > Ohh, scratch that. The patch is bogus. I have completely missed that > > > vmemmap_populate_hugepages already falls back to > > > vmemmap_populate_basepages. I have to revisit the bug report I have > > > received to see what happened apart from the allocation warning. Maybe > > > we just want to silent that warning. > > > > Yep, this should be fixed in 8e2cdbcb86b0 ("x86-64: fall back to > > regular page vmemmap on allocation failure"). > > > > I figure it's good to keep some sort of warning there, though, as it > > could have performance implications when we fall back to base pages. > > Yeah, but I am not really sure the allocation warning is the right thing > here because it is just too verbose. If you consider that we will get > this warning for each memory section (128MB or 2GB)... I guess the > existing > pr_warn_once("vmemmap: falling back to regular page backing\n"); > > or maybe make it pr_warn should be enough. What do you think? It could be useful to dump the memory context at least once, to 1) let the user know we're falling back but also 2) to get the default report we split out anytime we fail in a low-memory situation - in case there is a problem with the MM subsystem. Maybe something along the lines of this? (totally untested) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index 95651dc58e09..d03c8f244e5b 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -1302,7 +1302,6 @@ static int __meminit vmemmap_populate_hugepages(unsigned long start, vmemmap_verify((pte_t *)pmd, node, addr, next); continue; } - pr_warn_once("vmemmap: falling back to regular page backing\n"); if (vmemmap_populate_basepages(addr, next, node)) return -ENOMEM; } diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index a56c3989f773..efd3f48c667c 100644 --- a/mm/sparse-vmemmap.c +++ b/mm/sparse-vmemmap.c @@ -52,18 +52,24 @@ void * __meminit vmemmap_alloc_block(unsigned long size, int node) { /* If the main allocator is up use that, fallback to bootmem. */ if (slab_is_available()) { + unsigned int order; + static int warned; struct page *page; + gfp_t gfp_mask; + order = get_order(size); + gfp_mask = GFP_KERNEL|__GFP_ZERO|__GFP_REPEAT|__GFP_NOWARN; if (node_state(node, N_HIGH_MEMORY)) - page = alloc_pages_node( - node, GFP_KERNEL | __GFP_ZERO | __GFP_REPEAT, - get_order(size)); + page = alloc_pages_node(node, gfp_mask, size); else - page = alloc_pages( - GFP_KERNEL | __GFP_ZERO | __GFP_REPEAT, - get_order(size)); + page = alloc_pages(gfp_mask, size); if (page) return page_address(page); + if (!warned) { + warn_alloc(gfp_mask, NULL, + "vmemmap alloc failure: order:%u", order); + warned = 1; + } return NULL; } else return __earlyonly_bootmem_alloc(node, size, size, -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-07-11 21:45 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-11 13:42 [PATCH] vmemmap, memory_hotplug: fallback to base pages for vmmap Michal Hocko 2017-07-11 13:42 ` Michal Hocko 2017-07-11 14:25 ` Michal Hocko 2017-07-11 14:25 ` Michal Hocko 2017-07-11 17:26 ` Johannes Weiner 2017-07-11 17:26 ` Johannes Weiner 2017-07-11 18:06 ` Christoph Lameter 2017-07-11 18:06 ` Christoph Lameter 2017-07-11 21:25 ` Michal Hocko 2017-07-11 21:25 ` Michal Hocko 2017-07-11 21:45 ` Johannes Weiner [this message] 2017-07-11 21:45 ` Johannes Weiner 2017-07-12 9:03 ` Michal Hocko 2017-07-12 9:03 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170711214541.GA11141@cmpxchg.org \ --to=hannes@cmpxchg.org \ --cc=akpm@linux-foundation.org \ --cc=cl@linux.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@kernel.org \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.