From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934166AbdGKVvT (ORCPT ); Tue, 11 Jul 2017 17:51:19 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51988 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933186AbdGKVvR (ORCPT ); Tue, 11 Jul 2017 17:51:17 -0400 Date: Tue, 11 Jul 2017 14:51:05 -0700 From: Ram Pai To: Benjamin Herrenschmidt Cc: Dave Hansen , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, arnd@arndb.de, corbet@lwn.net, mingo@redhat.com, paulus@samba.org, aneesh.kumar@linux.vnet.ibm.com, akpm@linux-foundation.org, khandual@linux.vnet.ibm.com Subject: Re: [RFC v5 12/38] mm: ability to disable execute permission on a key at creation Reply-To: Ram Pai References: <1499289735-14220-1-git-send-email-linuxram@us.ibm.com> <1499289735-14220-13-git-send-email-linuxram@us.ibm.com> <3bd2ffd4-33ad-ce23-3db1-d1292e69ca9b@intel.com> <1499808577.2865.30.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499808577.2865.30.camel@kernel.crashing.org> User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-GCONF: 00 x-cbid: 17071121-0044-0000-0000-0000036B42CA X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007351; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00886196; UDB=6.00442336; IPR=6.00666346; BA=6.00005468; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016184; XFM=3.00000015; UTC=2017-07-11 21:51:14 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17071121-0045-0000-0000-000007994676 Message-Id: <20170711215105.GA5542@ram.oc3035372033.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-11_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1707110349 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 12, 2017 at 07:29:37AM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2017-07-11 at 11:11 -0700, Dave Hansen wrote: > > On 07/05/2017 02:21 PM, Ram Pai wrote: > > > Currently sys_pkey_create() provides the ability to disable read > > > and write permission on the key, at creation. powerpc has the > > > hardware support to disable execute on a pkey as well.This patch > > > enhances the interface to let disable execute at key creation > > > time. x86 does not allow this. Hence the next patch will add > > > ability in x86 to return error if PKEY_DISABLE_EXECUTE is > > > specified. > > That leads to the question... How do you tell userspace. > > (apologies if I missed that in an existing patch in the series) > > How do we inform userspace of the key capabilities ? There are at least > two things userspace may want to know already: > > - What protection bits are supported for a key the userspace is the one which allocates the keys and enables/disables the protection bits on the key. the kernel is just a facilitator. Now if the use space wants to know the current permissions on a given key, it can just read the AMR/PKRU register on powerpc/intel respectively. > > - How many keys exist There is no standard way of finding this other than trying to allocate as many till you fail. A procfs or sysfs file can be added to expose this information. > > - Which keys are available for use by userspace. On PowerPC, the > kernel can reserve some keys for itself, so can the hypervisor. In > fact, they do. this information can be exposed through /proc or /sysfs I am sure there will be more demands and requirements as applications start leveraging these feature. RP > > Cheers, > Ben. -- Ram Pai From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ram Pai Subject: Re: [RFC v5 12/38] mm: ability to disable execute permission on a key at creation Date: Tue, 11 Jul 2017 14:51:05 -0700 Message-ID: <20170711215105.GA5542@ram.oc3035372033.ibm.com> References: <1499289735-14220-1-git-send-email-linuxram@us.ibm.com> <1499289735-14220-13-git-send-email-linuxram@us.ibm.com> <3bd2ffd4-33ad-ce23-3db1-d1292e69ca9b@intel.com> <1499808577.2865.30.camel@kernel.crashing.org> Reply-To: Ram Pai Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1499808577.2865.30.camel@kernel.crashing.org> Sender: owner-linux-mm@kvack.org To: Benjamin Herrenschmidt Cc: Dave Hansen , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, arnd@arndb.de, corbet@lwn.net, mingo@redhat.com, paulus@samba.org, aneesh.kumar@linux.vnet.ibm.com, akpm@linux-foundation.org, khandual@linux.vnet.ibm.com List-Id: linux-arch.vger.kernel.org On Wed, Jul 12, 2017 at 07:29:37AM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2017-07-11 at 11:11 -0700, Dave Hansen wrote: > > On 07/05/2017 02:21 PM, Ram Pai wrote: > > > Currently sys_pkey_create() provides the ability to disable read > > > and write permission on the key, at creation. powerpc has the > > > hardware support to disable execute on a pkey as well.This patch > > > enhances the interface to let disable execute at key creation > > > time. x86 does not allow this. Hence the next patch will add > > > ability in x86 to return error if PKEY_DISABLE_EXECUTE is > > > specified. > > That leads to the question... How do you tell userspace. > > (apologies if I missed that in an existing patch in the series) > > How do we inform userspace of the key capabilities ? There are at least > two things userspace may want to know already: > > - What protection bits are supported for a key the userspace is the one which allocates the keys and enables/disables the protection bits on the key. the kernel is just a facilitator. Now if the use space wants to know the current permissions on a given key, it can just read the AMR/PKRU register on powerpc/intel respectively. > > - How many keys exist There is no standard way of finding this other than trying to allocate as many till you fail. A procfs or sysfs file can be added to expose this information. > > - Which keys are available for use by userspace. On PowerPC, the > kernel can reserve some keys for itself, so can the hypervisor. In > fact, they do. this information can be exposed through /proc or /sysfs I am sure there will be more demands and requirements as applications start leveraging these feature. RP > > Cheers, > Ben. -- Ram Pai -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org