From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752496AbdGLNpF (ORCPT ); Wed, 12 Jul 2017 09:45:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:35748 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036AbdGLNpE (ORCPT ); Wed, 12 Jul 2017 09:45:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3D3022B4D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 12 Jul 2017 09:45:01 -0400 From: Steven Rostedt To: Dan Carpenter Cc: Ingo Molnar , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 2/2] ftrace: silence uninitialized variable warning Message-ID: <20170712094501.4579732f@gandalf.local.home> In-Reply-To: <20170712073556.h6tkpjcdzjaozozs@mwanda> References: <20170712073340.4enzeojeoupuds5a@mwanda> <20170712073556.h6tkpjcdzjaozozs@mwanda> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 Jul 2017 10:35:57 +0300 Dan Carpenter wrote: > My static checker complains that if "func" is NULL then "clear_filter" > is uninitialized. This seems like it could be true, although it's > possible something subtle is happening that I haven't seen. > > kernel/trace/ftrace.c:3844 match_records() > error: uninitialized symbol 'clear_filter'. > > Signed-off-by: Dan Carpenter > --- > It does occur to me that I could initialize it to 1 instead of 0 but my > guess is that zero is intended. Please review this one carefully. Looks like it broke with f0a3b154bd7 ("ftrace: Clarify code for mod command"). Yeah, clear_filter = 0 is the correct default. Thanks! -- Steve > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index 2a3c45743f54..5e658da91912 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -3816,7 +3816,7 @@ match_records(struct ftrace_hash *hash, char *func, int len, char *mod) > int exclude_mod = 0; > int found = 0; > int ret; > - int clear_filter; > + int clear_filter = 0; > > if (func) { > func_g.type = filter_parse_regex(func, len, &func_g.search, From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Date: Wed, 12 Jul 2017 13:45:01 +0000 Subject: Re: [PATCH 2/2] ftrace: silence uninitialized variable warning Message-Id: <20170712094501.4579732f@gandalf.local.home> List-Id: References: <20170712073340.4enzeojeoupuds5a@mwanda> <20170712073556.h6tkpjcdzjaozozs@mwanda> In-Reply-To: <20170712073556.h6tkpjcdzjaozozs@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Ingo Molnar , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Wed, 12 Jul 2017 10:35:57 +0300 Dan Carpenter wrote: > My static checker complains that if "func" is NULL then "clear_filter" > is uninitialized. This seems like it could be true, although it's > possible something subtle is happening that I haven't seen. > > kernel/trace/ftrace.c:3844 match_records() > error: uninitialized symbol 'clear_filter'. > > Signed-off-by: Dan Carpenter > --- > It does occur to me that I could initialize it to 1 instead of 0 but my > guess is that zero is intended. Please review this one carefully. Looks like it broke with f0a3b154bd7 ("ftrace: Clarify code for mod command"). Yeah, clear_filter = 0 is the correct default. Thanks! -- Steve > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index 2a3c45743f54..5e658da91912 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -3816,7 +3816,7 @@ match_records(struct ftrace_hash *hash, char *func, int len, char *mod) > int exclude_mod = 0; > int found = 0; > int ret; > - int clear_filter; > + int clear_filter = 0; > > if (func) { > func_g.type = filter_parse_regex(func, len, &func_g.search,