All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhangweiping@didichuxing.com (weiping zhang)
Subject: [PATCH] nvme: add wrapper for nvme ctrl register r/w
Date: Wed, 12 Jul 2017 21:25:18 +0800	[thread overview]
Message-ID: <20170712132518.GA14560@localhost.didichuxing.com> (raw)
In-Reply-To: <20170712120152.GD4115@linux-x5ow.site>

On Wed, Jul 12, 2017@02:01:52PM +0200, Johannes Thumshirn wrote:
> On Wed, Jul 12, 2017@01:55:47PM +0200, Christoph Hellwig wrote:
> > Mostly because it's a little shorter and we're only going to get
> > more and more of these calls.  In the end I don't feel strongly
> > and we can just skip the patch for now and reconsider it once
> > we have more register read/write calls.
> 
> I'm in favour of the patch as well. It hides the transport specific
> implementation details quite good.
> 

Thanks all of your suggestions, I just want add a common interface of
register read/write. If someday we change the path of read/write
register, we only need modify nvme_ctrl_reg_xxx than every
ctrl->ops->xxx.

  reply	other threads:[~2017-07-12 13:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29 17:26 [PATCH] nvme: add wrapper for nvme ctrl register r/w weiping zhang
2017-07-12  7:20 ` Christoph Hellwig
2017-07-12 10:34   ` Sagi Grimberg
2017-07-12 11:55     ` Christoph Hellwig
2017-07-12 12:01       ` Johannes Thumshirn
2017-07-12 13:25         ` weiping zhang [this message]
2017-07-14  9:57         ` weiping zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170712132518.GA14560@localhost.didichuxing.com \
    --to=zhangweiping@didichuxing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.