All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed
Date: Wed, 12 Jul 2017 16:34:28 +0200	[thread overview]
Message-ID: <20170712143428.11953-1-maxime.ripard@free-electrons.com> (raw)

The -mno-unaligned-access flag used on ARM to prevent GCC from generating
unaligned accesses (obviously) will only do so on packed structures.

It seems like gcc 7.1 is a bit stricter than previous gcc versions on this,
and using it lead to data abort for unaligned accesses when generating
network traffic.

Fix this by adding the packed attribute to the ip_udp_hdr structure in
order to let GCC do its job.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 include/net.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net.h b/include/net.h
index 997db9210a8f..7b815afffafa 100644
--- a/include/net.h
+++ b/include/net.h
@@ -390,7 +390,7 @@ struct ip_udp_hdr {
 	u16		udp_dst;	/* UDP destination port		*/
 	u16		udp_len;	/* Length of UDP packet		*/
 	u16		udp_xsum;	/* Checksum			*/
-};
+} __attribute__ ((packed));
 
 #define IP_UDP_HDR_SIZE		(sizeof(struct ip_udp_hdr))
 #define UDP_HDR_SIZE		(IP_UDP_HDR_SIZE - IP_HDR_SIZE)
-- 
2.13.0

             reply	other threads:[~2017-07-12 14:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-12 14:34 Maxime Ripard [this message]
2017-07-18 18:10 ` [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed Joe Hershberger
2017-07-19  7:01   ` Maxime Ripard
2017-07-19 18:13     ` Joe Hershberger
2017-07-19 18:26   ` Jeroen Hofstee
2017-07-21 18:46     ` Siarhei Siamashka
2017-07-22 13:32       ` Jeroen Hofstee
2017-07-19 18:14 ` Joe Hershberger
2017-07-12 14:34 Maxime Ripard
2017-07-12 14:37 ` Dr. Philipp Tomsich
2017-07-17  9:29   ` Maxime Ripard
2017-07-18  2:35     ` Tom Rini
2017-07-21 19:15 ` Siarhei Siamashka
2017-07-21 19:37   ` Siarhei Siamashka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170712143428.11953-1-maxime.ripard@free-electrons.com \
    --to=maxime.ripard@free-electrons.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.