From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756672AbdGLF0U (ORCPT ); Wed, 12 Jul 2017 01:26:20 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36419 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbdGLF0P (ORCPT ); Wed, 12 Jul 2017 01:26:15 -0400 Date: Wed, 12 Jul 2017 15:26:01 +1000 From: Balbir Singh To: Ram Pai Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, dave.hansen@intel.com, hbabu@us.ibm.com, arnd@arndb.de, akpm@linux-foundation.org, corbet@lwn.net, mingo@redhat.com Subject: Re: [RFC v5 15/38] powerpc: helper function to read,write AMR,IAMR,UAMOR registers Message-ID: <20170712152601.3b2f52ed@firefly.ozlabs.ibm.com> In-Reply-To: <1499289735-14220-16-git-send-email-linuxram@us.ibm.com> References: <1499289735-14220-1-git-send-email-linuxram@us.ibm.com> <1499289735-14220-16-git-send-email-linuxram@us.ibm.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 Jul 2017 14:21:52 -0700 Ram Pai wrote: > Implements helper functions to read and write the key related > registers; AMR, IAMR, UAMOR. > > AMR register tracks the read,write permission of a key > IAMR register tracks the execute permission of a key > UAMOR register enables and disables a key > > Signed-off-by: Ram Pai > --- > arch/powerpc/include/asm/book3s/64/pgtable.h | 60 ++++++++++++++++++++++++++ > 1 files changed, 60 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h > index 85bc987..435d6a7 100644 > --- a/arch/powerpc/include/asm/book3s/64/pgtable.h > +++ b/arch/powerpc/include/asm/book3s/64/pgtable.h > @@ -428,6 +428,66 @@ static inline void huge_ptep_set_wrprotect(struct mm_struct *mm, > pte_update(mm, addr, ptep, 0, _PAGE_PRIVILEGED, 1); > } > > +#ifdef CONFIG_PPC64_MEMORY_PROTECTION_KEYS > + > +#include > +static inline u64 read_amr(void) > +{ > + return mfspr(SPRN_AMR); > +} > +static inline void write_amr(u64 value) > +{ > + mtspr(SPRN_AMR, value); > +} > +static inline u64 read_iamr(void) > +{ > + return mfspr(SPRN_IAMR); > +} > +static inline void write_iamr(u64 value) > +{ > + mtspr(SPRN_IAMR, value); > +} > +static inline u64 read_uamor(void) > +{ > + return mfspr(SPRN_UAMOR); > +} > +static inline void write_uamor(u64 value) > +{ > + mtspr(SPRN_UAMOR, value); > +} > + > +#else /* CONFIG_PPC64_MEMORY_PROTECTION_KEYS */ > + > +static inline u64 read_amr(void) > +{ > + WARN(1, "%s called with MEMORY PROTECTION KEYS disabled\n", __func__); > + return -1; > +} Why do we need to have a version here if we are going to WARN(), why not let the compilation fail if called from outside of CONFIG_PPC64_MEMORY_PROTECTION_KEYS? Is that the intention? Balbir Singh From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balbir Singh Subject: Re: [RFC v5 15/38] powerpc: helper function to read,write AMR,IAMR,UAMOR registers Date: Wed, 12 Jul 2017 15:26:01 +1000 Message-ID: <20170712152601.3b2f52ed@firefly.ozlabs.ibm.com> References: <1499289735-14220-1-git-send-email-linuxram@us.ibm.com> <1499289735-14220-16-git-send-email-linuxram@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1499289735-14220-16-git-send-email-linuxram@us.ibm.com> Sender: owner-linux-mm@kvack.org To: Ram Pai Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, dave.hansen@intel.com, hbabu@us.ibm.com, arnd@arndb.de, akpm@linux-foundation.org, corbet@lwn.net, mingo@redhat.com List-Id: linux-arch.vger.kernel.org On Wed, 5 Jul 2017 14:21:52 -0700 Ram Pai wrote: > Implements helper functions to read and write the key related > registers; AMR, IAMR, UAMOR. > > AMR register tracks the read,write permission of a key > IAMR register tracks the execute permission of a key > UAMOR register enables and disables a key > > Signed-off-by: Ram Pai > --- > arch/powerpc/include/asm/book3s/64/pgtable.h | 60 ++++++++++++++++++++++++++ > 1 files changed, 60 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h > index 85bc987..435d6a7 100644 > --- a/arch/powerpc/include/asm/book3s/64/pgtable.h > +++ b/arch/powerpc/include/asm/book3s/64/pgtable.h > @@ -428,6 +428,66 @@ static inline void huge_ptep_set_wrprotect(struct mm_struct *mm, > pte_update(mm, addr, ptep, 0, _PAGE_PRIVILEGED, 1); > } > > +#ifdef CONFIG_PPC64_MEMORY_PROTECTION_KEYS > + > +#include > +static inline u64 read_amr(void) > +{ > + return mfspr(SPRN_AMR); > +} > +static inline void write_amr(u64 value) > +{ > + mtspr(SPRN_AMR, value); > +} > +static inline u64 read_iamr(void) > +{ > + return mfspr(SPRN_IAMR); > +} > +static inline void write_iamr(u64 value) > +{ > + mtspr(SPRN_IAMR, value); > +} > +static inline u64 read_uamor(void) > +{ > + return mfspr(SPRN_UAMOR); > +} > +static inline void write_uamor(u64 value) > +{ > + mtspr(SPRN_UAMOR, value); > +} > + > +#else /* CONFIG_PPC64_MEMORY_PROTECTION_KEYS */ > + > +static inline u64 read_amr(void) > +{ > + WARN(1, "%s called with MEMORY PROTECTION KEYS disabled\n", __func__); > + return -1; > +} Why do we need to have a version here if we are going to WARN(), why not let the compilation fail if called from outside of CONFIG_PPC64_MEMORY_PROTECTION_KEYS? Is that the intention? Balbir Singh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org