From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753967AbdGLQkR (ORCPT ); Wed, 12 Jul 2017 12:40:17 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:52982 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753430AbdGLQkQ (ORCPT ); Wed, 12 Jul 2017 12:40:16 -0400 Date: Wed, 12 Jul 2017 09:40:08 -0700 From: Sukadev Bhattiprolu To: Arnaldo Carvalho de Melo Cc: Michael Ellerman , Jiri Olsa , Madhavan Srinivasan , Andi Kleen , ak@linux.intel.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, mikey@neuling.org, mpetlan@redhat.com Subject: Re: [GIT PULL] Please pull JSON files for Power9 PMU events References: <20170712020827.GB31223@us.ibm.com> <87a849luvr.fsf@concordia.ellerman.id.au> <20170712144611.GN27350@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170712144611.GN27350@kernel.org> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.7.1 (2016-10-04) X-TM-AS-GCONF: 00 x-cbid: 17071216-0004-0000-0000-000012911826 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007356; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00886572; UDB=6.00442562; IPR=6.00666722; BA=6.00005468; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016198; XFM=3.00000015; UTC=2017-07-12 16:40:13 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17071216-0005-0000-0000-00008032E4AF Message-Id: <20170712164008.GC31223@us.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-12_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1707120271 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnaldo Carvalho de Melo [acme@kernel.org] wrote: > Em Wed, Jul 12, 2017 at 10:09:12PM +1000, Michael Ellerman escreveu: > > Sukadev Bhattiprolu writes: > > > Please pull the JSON files for POWER9 PMU events. > > > > perf vendor events: Add POWER9 PMU events > > > perf vendor events: Add POWER9 PVRs to mapfile > > > I think the PVRs need work. > > > You have: > > > +004e0100,1,power9.json,core > > +004e0000,1,power9.json,core > > > The first is P9 DD1, but the second doesn't exist. We have it in the > > kernel, but with a mask of 0xffff0000. From memory the perf code doesn't > > do any masking or anything fancy, it looks for an exact match. > > > So for starters you should probably drop that one and add 0x004e1200 and > > 0x004e0200. Yes, thanks. > > Could this check be somehow done automatically? Using whatever is in the > kernel sources or some IBM released document? Yes, had a recent discussion offline with Michael Petlan and Jiri about generalizing/simplifying this. For now, I have added the above PVRs and will look into the broader fix. The following changes since commit 07d306c838c5c30196619baae36107d0615e459b: Merge git://www.linux-watchdog.org/linux-watchdog (2017-07-11 09:59:37 -0700) are available in the git repository at: https://github.com/sukadev/linux/ p9-json for you to fetch changes up to 8870b54739866c6eea23c36a0125af8045fbd572: perf vendor events: Add POWER9 PVRs to mapfile (2017-07-12 11:11:00 -0500) ---------------------------------------------------------------- Sukadev Bhattiprolu (2): perf vendor events: Add POWER9 PMU events perf vendor events: Add POWER9 PVRs to mapfile tools/perf/pmu-events/arch/powerpc/mapfile.csv | 3 + .../perf/pmu-events/arch/powerpc/power9/cache.json | 176 +++++ .../arch/powerpc/power9/floating-point.json | 44 ++ .../pmu-events/arch/powerpc/power9/frontend.json | 446 +++++++++++ .../pmu-events/arch/powerpc/power9/marked.json | 782 +++++++++++++++++++ .../pmu-events/arch/powerpc/power9/memory.json | 158 ++++ .../perf/pmu-events/arch/powerpc/power9/other.json | 836 +++++++++++++++++++++ .../pmu-events/arch/powerpc/power9/pipeline.json | 680 +++++++++++++++++ tools/perf/pmu-events/arch/powerpc/power9/pmc.json | 146 ++++ .../arch/powerpc/power9/translation.json | 272 +++++++ 10 files changed, 3543 insertions(+) create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/cache.json create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/floating-point.json create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/frontend.json create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/marked.json create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/memory.json create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/other.json create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/pipeline.json create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/pmc.json create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/translation.json