From: "Emilio G. Cota" <cota@braap.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 06/22] translate-all: make have_tb_lock static
Date: Wed, 12 Jul 2017 14:22:20 -0400 [thread overview]
Message-ID: <20170712182220.GB7547@flamenco> (raw)
In-Reply-To: <87lgnt90uz.fsf@linaro.org>
On Wed, Jul 12, 2017 at 15:38:28 +0100, Alex Bennée wrote:
>
> Emilio G. Cota <cota@braap.org> writes:
>
> > It is only used by this object, and it's not exported to any other.
> >
> > Signed-off-by: Emilio G. Cota <cota@braap.org>
>
> I was almost caught out by the name re-use in cpu-exec.c ;-)
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Yes that's very unfortunate. In v2 I'll add a patch to rename it.
Thanks,
E.
next prev parent reply other threads:[~2017-07-12 18:22 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 7:49 [Qemu-devel] [PATCH 00/22] tcg: per-thread TCG Emilio G. Cota
2017-07-09 7:49 ` [Qemu-devel] [PATCH 01/22] vl: fix breakage of -tb-size Emilio G. Cota
2017-07-09 19:56 ` Richard Henderson
2017-07-11 15:37 ` Alex Bennée
2017-07-09 7:49 ` [Qemu-devel] [PATCH 02/22] translate-all: remove redundant !tcg_enabled check in dump_exec_info Emilio G. Cota
2017-07-09 19:57 ` Richard Henderson
2017-07-10 6:15 ` Thomas Huth
2017-07-12 12:32 ` Alex Bennée
2017-07-09 7:49 ` [Qemu-devel] [PATCH 03/22] cputlb: bring back tlb_flush_count under !TLB_DEBUG Emilio G. Cota
2017-07-09 20:00 ` Richard Henderson
2017-07-09 20:56 ` Emilio G. Cota
2017-07-09 21:20 ` Emilio G. Cota
2017-07-12 13:26 ` Alex Bennée
2017-07-12 18:19 ` Emilio G. Cota
2017-07-09 7:49 ` [Qemu-devel] [PATCH 04/22] tcg: fix corruption of code_time profiling counter upon tb_flush Emilio G. Cota
2017-07-09 20:01 ` Richard Henderson
2017-07-12 14:36 ` Alex Bennée
2017-07-12 17:09 ` Philippe Mathieu-Daudé
2017-07-09 7:49 ` [Qemu-devel] [PATCH 05/22] exec-all: fix typos in TranslationBlock's documentation Emilio G. Cota
2017-07-12 14:37 ` Alex Bennée
2017-07-09 7:49 ` [Qemu-devel] [PATCH 06/22] translate-all: make have_tb_lock static Emilio G. Cota
2017-07-09 20:02 ` Richard Henderson
2017-07-12 14:38 ` Alex Bennée
2017-07-12 18:22 ` Emilio G. Cota [this message]
2017-07-09 7:49 ` [Qemu-devel] [PATCH 07/22] tcg/i386: constify tcg_target_callee_save_regs Emilio G. Cota
2017-07-09 20:02 ` Richard Henderson
2017-07-12 14:39 ` Alex Bennée
2017-07-12 17:00 ` Philippe Mathieu-Daudé
2017-07-09 7:50 ` [Qemu-devel] [PATCH 08/22] tcg/mips: " Emilio G. Cota
2017-07-09 20:02 ` Richard Henderson
2017-07-12 14:39 ` Alex Bennée
2017-07-12 17:01 ` Philippe Mathieu-Daudé
2017-07-09 7:50 ` [Qemu-devel] [PATCH 09/22] exec-all: shrink tb->invalid to uint8_t Emilio G. Cota
2017-07-09 20:11 ` Richard Henderson
2017-07-10 23:57 ` Emilio G. Cota
2017-07-12 0:53 ` Richard Henderson
2017-07-12 20:48 ` Emilio G. Cota
2017-07-12 23:06 ` Richard Henderson
2017-07-16 1:43 ` Emilio G. Cota
2017-07-16 7:22 ` Richard Henderson
2017-07-09 7:50 ` [Qemu-devel] [PATCH 10/22] exec-all: move tb->invalid to the end of the struct Emilio G. Cota
2017-07-09 7:50 ` [Qemu-devel] [PATCH 11/22] translate-all: use a binary search tree to track TBs in TBContext Emilio G. Cota
2017-07-09 20:33 ` Richard Henderson
2017-07-09 21:01 ` Emilio G. Cota
2017-07-12 15:10 ` Alex Bennée
2017-07-12 18:38 ` Emilio G. Cota
2017-07-09 7:50 ` [Qemu-devel] [PATCH 12/22] translate-all: report correct avg host TB size Emilio G. Cota
2017-07-12 15:25 ` Alex Bennée
2017-07-12 18:45 ` Emilio G. Cota
2017-07-09 7:50 ` [Qemu-devel] [PATCH 13/22] tcg: take tb_ctx out of TCGContext Emilio G. Cota
2017-07-12 15:27 ` Alex Bennée
2017-07-09 7:50 ` [Qemu-devel] [PATCH 14/22] tcg: take .helpers " Emilio G. Cota
2017-07-09 20:35 ` Richard Henderson
2017-07-12 15:28 ` Alex Bennée
2017-07-09 7:50 ` [Qemu-devel] [PATCH 15/22] gen-icount: fold exitreq_label into TCGContext Emilio G. Cota
2017-07-09 20:36 ` Richard Henderson
2017-07-12 15:29 ` Alex Bennée
2017-07-09 7:50 ` [Qemu-devel] [PATCH 16/22] tcg: keep a list of TCGContext's Emilio G. Cota
2017-07-09 20:43 ` Richard Henderson
2017-07-12 15:32 ` Alex Bennée
2017-07-09 7:50 ` [Qemu-devel] [PATCH 17/22] tcg: distribute profiling counters across TCGContext's Emilio G. Cota
2017-07-09 20:45 ` Richard Henderson
2017-07-09 21:14 ` Emilio G. Cota
2017-07-09 21:44 ` Richard Henderson
2017-07-10 16:00 ` Emilio G. Cota
2017-07-09 7:50 ` [Qemu-devel] [PATCH 18/22] tcg: define TCG_HIGHWATER Emilio G. Cota
2017-07-09 20:46 ` Richard Henderson
2017-07-12 15:33 ` Alex Bennée
2017-07-09 7:50 ` [Qemu-devel] [PATCH 19/22] tcg: introduce tcg_context_clone Emilio G. Cota
2017-07-09 20:48 ` Richard Henderson
2017-07-09 21:04 ` Emilio G. Cota
2017-07-12 16:02 ` Alex Bennée
2017-07-12 17:25 ` Richard Henderson
2017-07-12 17:47 ` Alex Bennée
2017-07-09 7:50 ` [Qemu-devel] [PATCH 20/22] tcg: dynamically allocate from code_gen_buffer using equally-sized regions Emilio G. Cota
2017-07-09 21:03 ` Richard Henderson
2017-07-09 7:50 ` [Qemu-devel] [PATCH 21/22] tcg: enable per-thread TCG for softmmu Emilio G. Cota
2017-07-09 21:07 ` Richard Henderson
2017-07-09 21:19 ` Richard Henderson
2017-07-09 21:29 ` Emilio G. Cota
2017-07-09 21:48 ` Richard Henderson
2017-07-10 3:54 ` Emilio G. Cota
2017-07-10 12:05 ` Paolo Bonzini
2017-07-10 21:14 ` Emilio G. Cota
2017-07-10 21:33 ` Paolo Bonzini
2017-07-10 22:13 ` Emilio G. Cota
2017-07-11 8:02 ` Paolo Bonzini
2017-07-09 7:50 ` [Qemu-devel] [PATCH 22/22] translate-all: do not hold tb_lock during code generation in softmmu Emilio G. Cota
2017-07-09 21:38 ` Richard Henderson
2017-07-10 3:51 ` Emilio G. Cota
2017-07-10 5:59 ` Richard Henderson
2017-07-10 15:28 ` Emilio G. Cota
2017-07-09 18:27 ` [Qemu-devel] [PATCH 00/22] tcg: per-thread TCG Emilio G. Cota
2017-07-10 9:50 ` Alex Bennée
2017-07-10 17:04 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712182220.GB7547@flamenco \
--to=cota@braap.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.