From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] migration: export capabilities to props
Date: Wed, 12 Jul 2017 19:59:53 +0100 [thread overview]
Message-ID: <20170712185952.GL30658@work-vm> (raw)
In-Reply-To: <1499842423-21101-4-git-send-email-peterx@redhat.com>
* Peter Xu (peterx@redhat.com) wrote:
> Do the same thing to migration capabilities, just like what we did in
> previous patch for migration parameters.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/migration.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index fd00670..7e6f353 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -2001,6 +2001,9 @@ void migration_global_dump(Monitor *mon)
> ms->send_configuration, ms->send_section_footer);
> }
>
> +#define DEFINE_PROP_MIG_CAP(name, x) \
> + DEFINE_PROP_BOOL(name, MigrationState, enabled_capabilities[x], false)
> +
> static Property migration_properties[] = {
> DEFINE_PROP_BOOL("store-global-state", MigrationState,
> store_global_state, true),
> @@ -2034,6 +2037,20 @@ static Property migration_properties[] = {
> DEFINE_PROP_INT64("x-checkpoint-delay", MigrationState,
> parameters.x_checkpoint_delay,
> DEFAULT_MIGRATE_X_CHECKPOINT_DELAY),
> +
> + /* Migration capabilities */
> + DEFINE_PROP_MIG_CAP("xbzrle", MIGRATION_CAPABILITY_XBZRLE),
> + DEFINE_PROP_MIG_CAP("rdma-pin-all", MIGRATION_CAPABILITY_RDMA_PIN_ALL),
> + DEFINE_PROP_MIG_CAP("auto-converge", MIGRATION_CAPABILITY_AUTO_CONVERGE),
> + DEFINE_PROP_MIG_CAP("zero-blocks", MIGRATION_CAPABILITY_ZERO_BLOCKS),
> + DEFINE_PROP_MIG_CAP("compress", MIGRATION_CAPABILITY_COMPRESS),
> + DEFINE_PROP_MIG_CAP("events", MIGRATION_CAPABILITY_EVENTS),
> + DEFINE_PROP_MIG_CAP("postcopy-ram", MIGRATION_CAPABILITY_POSTCOPY_RAM),
> + DEFINE_PROP_MIG_CAP("x-colo", MIGRATION_CAPABILITY_X_COLO),
> + DEFINE_PROP_MIG_CAP("release-ram", MIGRATION_CAPABILITY_RELEASE_RAM),
> + DEFINE_PROP_MIG_CAP("block", MIGRATION_CAPABILITY_BLOCK),
> + DEFINE_PROP_MIG_CAP("return-path", MIGRATION_CAPABILITY_RETURN_PATH),
> +
> DEFINE_PROP_END_OF_LIST(),
> };
>
> --
> 2.7.4
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2017-07-12 19:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 6:53 [Qemu-devel] [PATCH 0/3] migration: export cap/params to qdev props Peter Xu
2017-07-12 6:53 ` [Qemu-devel] [PATCH 1/3] qdev: provide DEFINE_PROP_INT64() Peter Xu
2017-07-13 16:05 ` Marc-André Lureau
2017-07-14 3:06 ` Peter Xu
2017-07-12 6:53 ` [Qemu-devel] [PATCH 2/3] migration: export parameters to props Peter Xu
2017-07-12 18:49 ` Dr. David Alan Gilbert
2017-07-12 6:53 ` [Qemu-devel] [PATCH 3/3] migration: export capabilities " Peter Xu
2017-07-12 18:59 ` Dr. David Alan Gilbert [this message]
2017-07-12 19:02 ` [Qemu-devel] [PATCH 0/3] migration: export cap/params to qdev props Dr. David Alan Gilbert
2017-07-14 4:23 ` Peter Xu
2017-07-14 15:57 ` Eduardo Habkost
2017-07-17 3:25 ` Peter Xu
2017-07-12 19:05 ` Eduardo Habkost
2017-07-14 5:04 ` Peter Xu
2017-07-14 16:01 ` Eduardo Habkost
2017-07-14 16:32 ` Dr. David Alan Gilbert
2017-07-17 3:06 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712185952.GL30658@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.