From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753919AbdGNLQj (ORCPT ); Fri, 14 Jul 2017 07:16:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:37238 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753840AbdGNLQh (ORCPT ); Fri, 14 Jul 2017 07:16:37 -0400 Date: Fri, 14 Jul 2017 12:16:33 +0100 From: Mel Gorman To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Vlastimil Babka , LKML , linux-api@vger.kernel.org Subject: Re: [PATCH 1/9] mm, page_alloc: rip out ZONELIST_ORDER_ZONE Message-ID: <20170714111633.gk5rpu2d5ghkbrrd@suse.de> References: <20170714080006.7250-1-mhocko@kernel.org> <20170714080006.7250-2-mhocko@kernel.org> <20170714093650.l67vbem2g4typkta@suse.de> <20170714104756.GD2618@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20170714104756.GD2618@dhcp22.suse.cz> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2017 at 12:47:57PM +0200, Michal Hocko wrote: > > That should to be "default" because the original code would have the proc > > entry display "default" unless it was set at runtime. Pretty weird I > > know but it's always possible someone is parsing the original default > > and not handling it properly. > > Ohh, right! That is indeed strange. Then I guess it would be probably > better to simply return Node to make it clear what the default is. What > do you think? > That would work too. The casing still matches. -- Mel Gorman SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mel Gorman Subject: Re: [PATCH 1/9] mm, page_alloc: rip out ZONELIST_ORDER_ZONE Date: Fri, 14 Jul 2017 12:16:33 +0100 Message-ID: <20170714111633.gk5rpu2d5ghkbrrd@suse.de> References: <20170714080006.7250-1-mhocko@kernel.org> <20170714080006.7250-2-mhocko@kernel.org> <20170714093650.l67vbem2g4typkta@suse.de> <20170714104756.GD2618@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Return-path: Content-Disposition: inline In-Reply-To: <20170714104756.GD2618-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michal Hocko Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Andrew Morton , Johannes Weiner , Vlastimil Babka , LKML , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On Fri, Jul 14, 2017 at 12:47:57PM +0200, Michal Hocko wrote: > > That should to be "default" because the original code would have the proc > > entry display "default" unless it was set at runtime. Pretty weird I > > know but it's always possible someone is parsing the original default > > and not handling it properly. > > Ohh, right! That is indeed strange. Then I guess it would be probably > better to simply return Node to make it clear what the default is. What > do you think? > That would work too. The casing still matches. -- Mel Gorman SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by kanga.kvack.org (Postfix) with ESMTP id DAE32440905 for ; Fri, 14 Jul 2017 07:16:37 -0400 (EDT) Received: by mail-wm0-f70.google.com with SMTP id 79so8741914wmg.4 for ; Fri, 14 Jul 2017 04:16:37 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id u62si2041924wmd.112.2017.07.14.04.16.36 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 14 Jul 2017 04:16:36 -0700 (PDT) Date: Fri, 14 Jul 2017 12:16:33 +0100 From: Mel Gorman Subject: Re: [PATCH 1/9] mm, page_alloc: rip out ZONELIST_ORDER_ZONE Message-ID: <20170714111633.gk5rpu2d5ghkbrrd@suse.de> References: <20170714080006.7250-1-mhocko@kernel.org> <20170714080006.7250-2-mhocko@kernel.org> <20170714093650.l67vbem2g4typkta@suse.de> <20170714104756.GD2618@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20170714104756.GD2618@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Vlastimil Babka , LKML , linux-api@vger.kernel.org On Fri, Jul 14, 2017 at 12:47:57PM +0200, Michal Hocko wrote: > > That should to be "default" because the original code would have the proc > > entry display "default" unless it was set at runtime. Pretty weird I > > know but it's always possible someone is parsing the original default > > and not handling it properly. > > Ohh, right! That is indeed strange. Then I guess it would be probably > better to simply return Node to make it clear what the default is. What > do you think? > That would work too. The casing still matches. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org