From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754092AbdGNMbD (ORCPT <rfc822;w@1wt.eu>);
        Fri, 14 Jul 2017 08:31:03 -0400
Received: from verein.lst.de ([213.95.11.211]:38980 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753599AbdGNMbC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 14 Jul 2017 08:31:02 -0400
Date: Fri, 14 Jul 2017 14:31:01 +0200
From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
        Keith Busch <keith.busch@intel.com>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
        Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] nvmet: Move serial number from controller to
        subsystem
Message-ID: <20170714123100.GD26187@lst.de>
References: <20170714120517.13552-1-jthumshirn@suse.de> <20170714120517.13552-2-jthumshirn@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170714120517.13552-2-jthumshirn@suse.de>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -	/* generate a random serial number as our controllers are ephemeral: */
> -	get_random_bytes(&ctrl->serial, sizeof(ctrl->serial));
> -
>  	kref_init(&ctrl->ref);
>  	ctrl->subsys = subsys;
>  
> @@ -928,6 +925,7 @@ struct nvmet_subsys *nvmet_subsys_alloc(const char *subsysnqn,
>  		return NULL;
>  
>  	subsys->ver = NVME_VS(1, 3, 0); /* NVMe 1.3.0 */
> +	get_random_bytes(&subsys->serial, sizeof(subsys->serial));

This removes the comment, which I think is fairly useful.

From mboxrd@z Thu Jan  1 00:00:00 1970
From: hch@lst.de (Christoph Hellwig)
Date: Fri, 14 Jul 2017 14:31:01 +0200
Subject: [PATCH v2 1/2] nvmet: Move serial number from controller to
 subsystem
In-Reply-To: <20170714120517.13552-2-jthumshirn@suse.de>
References: <20170714120517.13552-1-jthumshirn@suse.de>
 <20170714120517.13552-2-jthumshirn@suse.de>
Message-ID: <20170714123100.GD26187@lst.de>

> -	/* generate a random serial number as our controllers are ephemeral: */
> -	get_random_bytes(&ctrl->serial, sizeof(ctrl->serial));
> -
>  	kref_init(&ctrl->ref);
>  	ctrl->subsys = subsys;
>  
> @@ -928,6 +925,7 @@ struct nvmet_subsys *nvmet_subsys_alloc(const char *subsysnqn,
>  		return NULL;
>  
>  	subsys->ver = NVME_VS(1, 3, 0); /* NVMe 1.3.0 */
> +	get_random_bytes(&subsys->serial, sizeof(subsys->serial));

This removes the comment, which I think is fairly useful.