From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754135AbdGNMcL (ORCPT <rfc822;w@1wt.eu>);
        Fri, 14 Jul 2017 08:32:11 -0400
Received: from verein.lst.de ([213.95.11.211]:38988 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754104AbdGNMcJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 14 Jul 2017 08:32:09 -0400
Date: Fri, 14 Jul 2017 14:32:08 +0200
From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
        Keith Busch <keith.busch@intel.com>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
        Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] nvmet: preserve controller serial number
        between reboots
Message-ID: <20170714123208.GE26187@lst.de>
References: <20170714120517.13552-1-jthumshirn@suse.de> <20170714120517.13552-3-jthumshirn@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170714120517.13552-3-jthumshirn@suse.de>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patch itself looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

>  static struct configfs_attribute *nvmet_subsys_attrs[] = {
>  	&nvmet_subsys_attr_attr_allow_any_host,
>  	&nvmet_subsys_attr_version,
> +	&nvmet_subsys_attr_attr_serial,

but the new version attribute really needs the attr prefix so that
nvmetcli can pick it up.  And we should also add nvmetcli support
for it.  Can you do the rename before your series to ease backporting
as that should go into 3.12 (just like your serial number fix).

From mboxrd@z Thu Jan  1 00:00:00 1970
From: hch@lst.de (Christoph Hellwig)
Date: Fri, 14 Jul 2017 14:32:08 +0200
Subject: [PATCH v2 2/2] nvmet: preserve controller serial number
 between reboots
In-Reply-To: <20170714120517.13552-3-jthumshirn@suse.de>
References: <20170714120517.13552-1-jthumshirn@suse.de>
 <20170714120517.13552-3-jthumshirn@suse.de>
Message-ID: <20170714123208.GE26187@lst.de>

This patch itself looks good:

Reviewed-by: Christoph Hellwig <hch at lst.de>

>  static struct configfs_attribute *nvmet_subsys_attrs[] = {
>  	&nvmet_subsys_attr_attr_allow_any_host,
>  	&nvmet_subsys_attr_version,
> +	&nvmet_subsys_attr_attr_serial,

but the new version attribute really needs the attr prefix so that
nvmetcli can pick it up.  And we should also add nvmetcli support
for it.  Can you do the rename before your series to ease backporting
as that should go into 3.12 (just like your serial number fix).