From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754355AbdGNMqp (ORCPT <rfc822;w@1wt.eu>);
        Fri, 14 Jul 2017 08:46:45 -0400
Received: from mx2.suse.de ([195.135.220.15]:51644 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1754068AbdGNMqo (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 14 Jul 2017 08:46:44 -0400
Date: Fri, 14 Jul 2017 14:46:32 +0200
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <keith.busch@intel.com>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
        Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] nvmet: preserve controller serial number between
 reboots
Message-ID: <20170714124632.GA13633@linux-x5ow.site>
References: <20170714120517.13552-1-jthumshirn@suse.de>
 <20170714120517.13552-3-jthumshirn@suse.de>
 <20170714123208.GE26187@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20170714123208.GE26187@lst.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 14, 2017 at 02:32:08PM +0200, Christoph Hellwig wrote:
> This patch itself looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
> >  static struct configfs_attribute *nvmet_subsys_attrs[] = {
> >  	&nvmet_subsys_attr_attr_allow_any_host,
> >  	&nvmet_subsys_attr_version,
> > +	&nvmet_subsys_attr_attr_serial,
> 
> but the new version attribute really needs the attr prefix so that
> nvmetcli can pick it up.  And we should also add nvmetcli support
> for it.  Can you do the rename before your series to ease backporting
> as that should go into 3.12 (just like your serial number fix).
> 

Is it OK if I send the patches in the same series? 

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

From mboxrd@z Thu Jan  1 00:00:00 1970
From: jthumshirn@suse.de (Johannes Thumshirn)
Date: Fri, 14 Jul 2017 14:46:32 +0200
Subject: [PATCH v2 2/2] nvmet: preserve controller serial number between
 reboots
In-Reply-To: <20170714123208.GE26187@lst.de>
References: <20170714120517.13552-1-jthumshirn@suse.de>
 <20170714120517.13552-3-jthumshirn@suse.de>
 <20170714123208.GE26187@lst.de>
Message-ID: <20170714124632.GA13633@linux-x5ow.site>

On Fri, Jul 14, 2017@02:32:08PM +0200, Christoph Hellwig wrote:
> This patch itself looks good:
> 
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> 
> >  static struct configfs_attribute *nvmet_subsys_attrs[] = {
> >  	&nvmet_subsys_attr_attr_allow_any_host,
> >  	&nvmet_subsys_attr_version,
> > +	&nvmet_subsys_attr_attr_serial,
> 
> but the new version attribute really needs the attr prefix so that
> nvmetcli can pick it up.  And we should also add nvmetcli support
> for it.  Can you do the rename before your series to ease backporting
> as that should go into 3.12 (just like your serial number fix).
> 

Is it OK if I send the patches in the same series? 

-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850