From: Mel Gorman <mgorman@suse.de>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Vlastimil Babka <vbabka@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
linux-api@vger.kernel.org
Subject: Re: [PATCH 1/9] mm, page_alloc: rip out ZONELIST_ORDER_ZONE
Date: Fri, 14 Jul 2017 14:01:11 +0100 [thread overview]
Message-ID: <20170714130111.vwnddyuypd2lcyu4@suse.de> (raw)
In-Reply-To: <20170714125616.clbp4ezgtoon6cmk@suse.de>
On Fri, Jul 14, 2017 at 01:56:16PM +0100, Mel Gorman wrote:
> > if (!write) {
> > - int len = sizeof("Default");
> > - if (copy_to_user(buffer, "Default", len))
> > + int len = sizeof("Node");
> > + if (copy_to_user(buffer, "Node", len))
> > return -EFAULT;
>
> Ok for the name. But what's with using sizeof?
Bah, sizeof static compile-time string versus char *. Never mind.
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman-l3A5Bk7waGM@public.gmane.org>
To: Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Vlastimil Babka <vbabka-AlSwsSmVLrQ@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/9] mm, page_alloc: rip out ZONELIST_ORDER_ZONE
Date: Fri, 14 Jul 2017 14:01:11 +0100 [thread overview]
Message-ID: <20170714130111.vwnddyuypd2lcyu4@suse.de> (raw)
In-Reply-To: <20170714125616.clbp4ezgtoon6cmk-l3A5Bk7waGM@public.gmane.org>
On Fri, Jul 14, 2017 at 01:56:16PM +0100, Mel Gorman wrote:
> > if (!write) {
> > - int len = sizeof("Default");
> > - if (copy_to_user(buffer, "Default", len))
> > + int len = sizeof("Node");
> > + if (copy_to_user(buffer, "Node", len))
> > return -EFAULT;
>
> Ok for the name. But what's with using sizeof?
Bah, sizeof static compile-time string versus char *. Never mind.
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Vlastimil Babka <vbabka@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
linux-api@vger.kernel.org
Subject: Re: [PATCH 1/9] mm, page_alloc: rip out ZONELIST_ORDER_ZONE
Date: Fri, 14 Jul 2017 14:01:11 +0100 [thread overview]
Message-ID: <20170714130111.vwnddyuypd2lcyu4@suse.de> (raw)
In-Reply-To: <20170714125616.clbp4ezgtoon6cmk@suse.de>
On Fri, Jul 14, 2017 at 01:56:16PM +0100, Mel Gorman wrote:
> > if (!write) {
> > - int len = sizeof("Default");
> > - if (copy_to_user(buffer, "Default", len))
> > + int len = sizeof("Node");
> > + if (copy_to_user(buffer, "Node", len))
> > return -EFAULT;
>
> Ok for the name. But what's with using sizeof?
Bah, sizeof static compile-time string versus char *. Never mind.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-07-14 13:01 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 7:59 [PATCH 0/9] cleanup zonelists initialization Michal Hocko
2017-07-14 7:59 ` Michal Hocko
2017-07-14 7:59 ` Michal Hocko
2017-07-14 7:59 ` [PATCH 1/9] mm, page_alloc: rip out ZONELIST_ORDER_ZONE Michal Hocko
2017-07-14 7:59 ` Michal Hocko
2017-07-14 9:36 ` Mel Gorman
2017-07-14 9:36 ` Mel Gorman
2017-07-14 9:36 ` Mel Gorman
2017-07-14 10:47 ` Michal Hocko
2017-07-14 10:47 ` Michal Hocko
2017-07-14 11:16 ` Mel Gorman
2017-07-14 11:16 ` Mel Gorman
2017-07-14 11:16 ` Mel Gorman
2017-07-14 11:38 ` Michal Hocko
2017-07-14 11:38 ` Michal Hocko
2017-07-14 11:38 ` Michal Hocko
2017-07-14 12:56 ` Mel Gorman
2017-07-14 12:56 ` Mel Gorman
2017-07-14 13:01 ` Mel Gorman [this message]
2017-07-14 13:01 ` Mel Gorman
2017-07-14 13:01 ` Mel Gorman
2017-07-14 13:08 ` Michal Hocko
2017-07-14 13:08 ` Michal Hocko
2017-07-19 9:33 ` Vlastimil Babka
2017-07-19 9:33 ` Vlastimil Babka
2017-07-19 9:33 ` Vlastimil Babka
2017-07-19 13:44 ` Michal Hocko
2017-07-19 13:44 ` Michal Hocko
2017-07-19 13:44 ` Michal Hocko
2017-07-14 7:59 ` [PATCH 2/9] mm, page_alloc: remove boot pageset initialization from memory hotplug Michal Hocko
2017-07-14 7:59 ` Michal Hocko
2017-07-14 9:39 ` Mel Gorman
2017-07-14 9:39 ` Mel Gorman
2017-07-19 13:15 ` Vlastimil Babka
2017-07-19 13:15 ` Vlastimil Babka
2017-07-14 8:00 ` [PATCH 3/9] mm, page_alloc: do not set_cpu_numa_mem on empty nodes initialization Michal Hocko
2017-07-14 8:00 ` Michal Hocko
2017-07-14 9:48 ` Mel Gorman
2017-07-14 9:48 ` Mel Gorman
2017-07-14 10:50 ` Michal Hocko
2017-07-14 10:50 ` Michal Hocko
2017-07-14 12:32 ` Mel Gorman
2017-07-14 12:32 ` Mel Gorman
2017-07-14 12:39 ` Michal Hocko
2017-07-14 12:39 ` Michal Hocko
2017-07-14 12:56 ` Mel Gorman
2017-07-14 12:56 ` Mel Gorman
2017-07-19 13:19 ` Vlastimil Babka
2017-07-19 13:19 ` Vlastimil Babka
2017-07-14 8:00 ` [PATCH 4/9] mm, memory_hotplug: drop zone from build_all_zonelists Michal Hocko
2017-07-14 8:00 ` Michal Hocko
2017-07-19 13:33 ` Vlastimil Babka
2017-07-19 13:33 ` Vlastimil Babka
2017-07-20 8:15 ` Michal Hocko
2017-07-20 8:15 ` Michal Hocko
2017-07-14 8:00 ` [PATCH 5/9] mm, memory_hotplug: remove explicit build_all_zonelists from try_online_node Michal Hocko
2017-07-14 8:00 ` Michal Hocko
2017-07-14 12:14 ` Michal Hocko
2017-07-14 12:14 ` Michal Hocko
2017-07-20 6:13 ` Vlastimil Babka
2017-07-20 6:13 ` Vlastimil Babka
2017-07-14 8:00 ` [PATCH 6/9] mm, page_alloc: simplify zonelist initialization Michal Hocko
2017-07-14 8:00 ` Michal Hocko
2017-07-14 9:55 ` Mel Gorman
2017-07-14 9:55 ` Mel Gorman
2017-07-14 10:51 ` Michal Hocko
2017-07-14 10:51 ` Michal Hocko
2017-07-14 12:46 ` Mel Gorman
2017-07-14 12:46 ` Mel Gorman
2017-07-14 13:02 ` Michal Hocko
2017-07-14 13:02 ` Michal Hocko
2017-07-14 14:18 ` Mel Gorman
2017-07-14 14:18 ` Mel Gorman
2017-07-17 6:06 ` Michal Hocko
2017-07-17 6:06 ` Michal Hocko
2017-07-17 8:07 ` Mel Gorman
2017-07-17 8:07 ` Mel Gorman
2017-07-17 8:19 ` Michal Hocko
2017-07-17 8:19 ` Michal Hocko
2017-07-17 8:58 ` Mel Gorman
2017-07-17 8:58 ` Mel Gorman
2017-07-17 9:15 ` Michal Hocko
2017-07-17 9:15 ` Michal Hocko
2017-07-20 6:55 ` Vlastimil Babka
2017-07-20 6:55 ` Vlastimil Babka
2017-07-20 7:19 ` Michal Hocko
2017-07-20 7:19 ` Michal Hocko
2017-07-14 8:00 ` [PATCH 7/9] mm, page_alloc: remove stop_machine from build_all_zonelists Michal Hocko
2017-07-14 8:00 ` Michal Hocko
2017-07-14 9:59 ` Mel Gorman
2017-07-14 9:59 ` Mel Gorman
2017-07-14 11:00 ` Michal Hocko
2017-07-14 11:00 ` Michal Hocko
2017-07-14 12:47 ` Mel Gorman
2017-07-14 12:47 ` Mel Gorman
2017-07-14 11:29 ` Vlastimil Babka
2017-07-14 11:29 ` Vlastimil Babka
2017-07-14 11:43 ` Michal Hocko
2017-07-14 11:43 ` Michal Hocko
2017-07-14 11:45 ` Michal Hocko
2017-07-14 11:45 ` Michal Hocko
2017-07-20 6:16 ` Vlastimil Babka
2017-07-20 6:16 ` Vlastimil Babka
2017-07-20 7:24 ` Vlastimil Babka
2017-07-20 7:24 ` Vlastimil Babka
2017-07-20 9:21 ` Michal Hocko
2017-07-20 9:21 ` Michal Hocko
2017-07-14 8:00 ` [PATCH 8/9] mm, memory_hotplug: get rid of zonelists_mutex Michal Hocko
2017-07-14 8:00 ` Michal Hocko
2017-07-14 8:00 ` [PATCH 9/9] mm, sparse, page_ext: drop ugly N_HIGH_MEMORY branches for allocations Michal Hocko
2017-07-14 8:00 ` Michal Hocko
2017-07-20 8:04 ` Vlastimil Babka
2017-07-20 8:04 ` Vlastimil Babka
2017-07-21 14:39 [PATCH -v1 0/9] cleanup zonelists initialization Michal Hocko
2017-07-21 14:39 ` [PATCH 1/9] mm, page_alloc: rip out ZONELIST_ORDER_ZONE Michal Hocko
2017-07-21 14:39 ` Michal Hocko
2017-07-21 14:45 ` Michal Hocko
2017-07-21 14:45 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714130111.vwnddyuypd2lcyu4@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.