From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH, RESEND 02/14] ata: avoid gcc-7 warning in ata_timing_quantize Date: Sat, 15 Jul 2017 06:56:01 -0400 Message-ID: <20170715105601.GC2969123@devbig577.frc2.facebook.com> References: <20170714092540.1217397-1-arnd@arndb.de> <20170714092540.1217397-3-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170714092540.1217397-3-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann Cc: Damien Le Moal , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-ide@vger.kernel.org, Geert Uytterhoeven , Hannes Reinecke , Adam Manzanares , akpm@linux-foundation.org, Mauro Carvalho Chehab , Linus Torvalds , Guenter Roeck , linux-media@vger.kernel.org List-Id: linux-ide@vger.kernel.org T24gRnJpLCBKdWwgMTQsIDIwMTcgYXQgMTE6MjU6MTRBTSArMDIwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBnY2MtNyB3YXJucyBhYm91dCB0aGUgcmVzdWx0IG9mIGEgY29uc3RhbnQgbXVsdGlw bGljYXRpb24gdXNlZCBhcwo+IGEgYm9vbGVhbjoKPiAKPiBkcml2ZXJzL2F0YS9saWJhdGEtY29y ZS5jOiBJbiBmdW5jdGlvbiAnYXRhX3RpbWluZ19xdWFudGl6ZSc6Cj4gZHJpdmVycy9hdGEvbGli YXRhLWNvcmUuYzozMTY0OjMwOiB3YXJuaW5nOiAnKicgaW4gYm9vbGVhbiBjb250ZXh0LCBzdWdn ZXN0ICcmJicgaW5zdGVhZCBbLVdpbnQtaW4tYm9vbC1jb250ZXh0XQo+IAo+IFRoaXMgc2xpZ2h0 bHkgcmVhcnJhbmdlcyB0aGUgbWFjcm8gdG8gc2ltcGxpZnkgdGhlIGNvZGUgYW5kIGF2b2lkCj4g dGhlIHdhcm5pbmcgYXQgdGhlIHNhbWUgdGltZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBcm5kIEJl cmdtYW5uIDxhcm5kQGFybmRiLmRlPgoKSWYgdGhlIHdob2xlIHNlcmllcyB3aWxsIGJlIHJvdXRl ZCB0b2dldGhlciwKCiBBY2tlZC1ieTogVGVqdW4gSGVvIDx0akBrZXJuZWwub3JnPgoKSWYgbm90 LCBwbGVhc2UgbGV0IG1lIGtub3cuICBJJ2xsIHB1c2ggaXQgdGhyb3VnaApsaWJhdGEvZm9yLTQu MTMtZml4ZXMuCgpUaGFua3MhCgotLSAKdGVqdW4KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751247AbdGOK4N (ORCPT ); Sat, 15 Jul 2017 06:56:13 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:36519 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161AbdGOK4K (ORCPT ); Sat, 15 Jul 2017 06:56:10 -0400 Date: Sat, 15 Jul 2017 06:56:01 -0400 From: Tejun Heo To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Linus Torvalds , Guenter Roeck , linux-ide@vger.kernel.org, linux-media@vger.kernel.org, akpm@linux-foundation.org, dri-devel@lists.freedesktop.org, Adam Manzanares , Mauro Carvalho Chehab , Hannes Reinecke , Geert Uytterhoeven , Damien Le Moal Subject: Re: [PATCH, RESEND 02/14] ata: avoid gcc-7 warning in ata_timing_quantize Message-ID: <20170715105601.GC2969123@devbig577.frc2.facebook.com> References: <20170714092540.1217397-1-arnd@arndb.de> <20170714092540.1217397-3-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170714092540.1217397-3-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2017 at 11:25:14AM +0200, Arnd Bergmann wrote: > gcc-7 warns about the result of a constant multiplication used as > a boolean: > > drivers/ata/libata-core.c: In function 'ata_timing_quantize': > drivers/ata/libata-core.c:3164:30: warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] > > This slightly rearranges the macro to simplify the code and avoid > the warning at the same time. > > Signed-off-by: Arnd Bergmann If the whole series will be routed together, Acked-by: Tejun Heo If not, please let me know. I'll push it through libata/for-4.13-fixes. Thanks! -- tejun