From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751300AbdGPSZB (ORCPT ); Sun, 16 Jul 2017 14:25:01 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:44206 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbdGPSY7 (ORCPT ); Sun, 16 Jul 2017 14:24:59 -0400 Date: Sun, 16 Jul 2017 20:24:58 +0200 From: Pavel Machek To: Alexandre Belloni Cc: "Rafael J. Wysocki" , Florian Fainelli , Mason , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Ulf Hansson , Daniel Lezcano , linux-pm , Thibaud Cornic , JB , Kevin Hilman , Linux ARM Subject: Re: [RFC 1/2] PM / suspend: Add platform_suspend_target_state() Message-ID: <20170716182457.GC14461@amd> References: <20170622085102.mpk7vxodpgxtrlfd@piout.net> <1703157.S2GHVxrQk4@aspire.rjw.lan> <3675920.H2f5xgTCgu@aspire.rjw.lan> <20170716133832.mnuaie4jnlwu6dwj@piout.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jy6Sn24JjFx/iggw" Content-Disposition: inline In-Reply-To: <20170716133832.mnuaie4jnlwu6dwj@piout.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jy6Sn24JjFx/iggw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > There still will be a concern regarding drivers that care about differe= nces between > > PM_SUSPEND_MEM and PM_SUSPEND_STANDBY, because those differences are > > platform-dependent, but let's defer addressing this until we have a dri= ver > > that needs to run on different platforms with different definitions for= those > > things. > >=20 >=20 > We already have the case for drivers/net/ethernet/cadence/ and > drivers/net/can/m_can/ and many of the at91 drivers. Depending on the > specific SoC they run on, PM_SUSPEND_MEM may or may not cut VDDcore or > may or may not change the peripheral clock. Please please introduce will_vddcore_be_cut_down() or similar helper, so that we have one place to fix.. Thanks, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --jy6Sn24JjFx/iggw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAllrr3kACgkQMOfwapXb+vLyZwCgg8lk+DtZzn2FA0ATwNAlK6EM vAsAoLjWMmWTYro3F6b8XZSaR4di4Am6 =+Baq -----END PGP SIGNATURE----- --jy6Sn24JjFx/iggw-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: pavel@ucw.cz (Pavel Machek) Date: Sun, 16 Jul 2017 20:24:58 +0200 Subject: [RFC 1/2] PM / suspend: Add platform_suspend_target_state() In-Reply-To: <20170716133832.mnuaie4jnlwu6dwj@piout.net> References: <20170622085102.mpk7vxodpgxtrlfd@piout.net> <1703157.S2GHVxrQk4@aspire.rjw.lan> <3675920.H2f5xgTCgu@aspire.rjw.lan> <20170716133832.mnuaie4jnlwu6dwj@piout.net> Message-ID: <20170716182457.GC14461@amd> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi! > > There still will be a concern regarding drivers that care about differences between > > PM_SUSPEND_MEM and PM_SUSPEND_STANDBY, because those differences are > > platform-dependent, but let's defer addressing this until we have a driver > > that needs to run on different platforms with different definitions for those > > things. > > > > We already have the case for drivers/net/ethernet/cadence/ and > drivers/net/can/m_can/ and many of the at91 drivers. Depending on the > specific SoC they run on, PM_SUSPEND_MEM may or may not cut VDDcore or > may or may not change the peripheral clock. Please please introduce will_vddcore_be_cut_down() or similar helper, so that we have one place to fix.. Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: Digital signature URL: