From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751386AbdGQI6O (ORCPT ); Mon, 17 Jul 2017 04:58:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:59362 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751329AbdGQI6H (ORCPT ); Mon, 17 Jul 2017 04:58:07 -0400 Date: Mon, 17 Jul 2017 09:58:04 +0100 From: Mel Gorman To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Vlastimil Babka , LKML Subject: Re: [PATCH 6/9] mm, page_alloc: simplify zonelist initialization Message-ID: <20170717085804.iujposlad2mxqh4l@suse.de> References: <20170714080006.7250-1-mhocko@kernel.org> <20170714080006.7250-7-mhocko@kernel.org> <20170714124645.i3duhuie6cczlybr@suse.de> <20170714130242.GQ2618@dhcp22.suse.cz> <20170714141823.2j7t37t6zdzdf3sv@suse.de> <20170717060639.GA7397@dhcp22.suse.cz> <20170717080723.wctyyukherj7bkqt@suse.de> <20170717081942.GA12888@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20170717081942.GA12888@dhcp22.suse.cz> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2017 at 10:19:42AM +0200, Michal Hocko wrote: > On Mon 17-07-17 09:07:23, Mel Gorman wrote: > > On Mon, Jul 17, 2017 at 08:06:40AM +0200, Michal Hocko wrote: > > > On Fri 14-07-17 15:18:23, Mel Gorman wrote: > > > > Fairly sure that's not what you meant. > > > > > > > > > > > > > pg_data_t *node = NODE_DATA(node_order[i]); > > > > > > > > > > - zoneref_idx = build_zonelists_node(node, zonelist, zoneref_idx); > > > > > + nr_zones = build_zonelists_node(node, zonelist, nr_zones); > > > > > > > > I meant converting build_zonelists_node and passing in &nr_zones and > > > > returning false when an empty node is encountered. In this context, > > > > it's also not about zones, it really is nr_zonerefs. Rename nr_zones in > > > > build_zonelists_node as well. > > > > > > hmm, why don't we rather make it zonerefs based then. Something > > > like the following? > > > > Works for me. > > Should I fold it to the patch or make it a patch on its own? I have no strong feelings either way but if it was folded then the overall naming should be easier to follow (at least for me). -- Mel Gorman SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f71.google.com (mail-wm0-f71.google.com [74.125.82.71]) by kanga.kvack.org (Postfix) with ESMTP id 142F86B0279 for ; Mon, 17 Jul 2017 04:58:08 -0400 (EDT) Received: by mail-wm0-f71.google.com with SMTP id g15so18718009wmi.11 for ; Mon, 17 Jul 2017 01:58:08 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id e133si3780051wmg.17.2017.07.17.01.58.06 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 17 Jul 2017 01:58:07 -0700 (PDT) Date: Mon, 17 Jul 2017 09:58:04 +0100 From: Mel Gorman Subject: Re: [PATCH 6/9] mm, page_alloc: simplify zonelist initialization Message-ID: <20170717085804.iujposlad2mxqh4l@suse.de> References: <20170714080006.7250-1-mhocko@kernel.org> <20170714080006.7250-7-mhocko@kernel.org> <20170714124645.i3duhuie6cczlybr@suse.de> <20170714130242.GQ2618@dhcp22.suse.cz> <20170714141823.2j7t37t6zdzdf3sv@suse.de> <20170717060639.GA7397@dhcp22.suse.cz> <20170717080723.wctyyukherj7bkqt@suse.de> <20170717081942.GA12888@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20170717081942.GA12888@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Vlastimil Babka , LKML On Mon, Jul 17, 2017 at 10:19:42AM +0200, Michal Hocko wrote: > On Mon 17-07-17 09:07:23, Mel Gorman wrote: > > On Mon, Jul 17, 2017 at 08:06:40AM +0200, Michal Hocko wrote: > > > On Fri 14-07-17 15:18:23, Mel Gorman wrote: > > > > Fairly sure that's not what you meant. > > > > > > > > > > > > > pg_data_t *node = NODE_DATA(node_order[i]); > > > > > > > > > > - zoneref_idx = build_zonelists_node(node, zonelist, zoneref_idx); > > > > > + nr_zones = build_zonelists_node(node, zonelist, nr_zones); > > > > > > > > I meant converting build_zonelists_node and passing in &nr_zones and > > > > returning false when an empty node is encountered. In this context, > > > > it's also not about zones, it really is nr_zonerefs. Rename nr_zones in > > > > build_zonelists_node as well. > > > > > > hmm, why don't we rather make it zonerefs based then. Something > > > like the following? > > > > Works for me. > > Should I fold it to the patch or make it a patch on its own? I have no strong feelings either way but if it was folded then the overall naming should be easier to follow (at least for me). -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org